Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: allow Host in HTTP/2 requests #34664

Closed
wants to merge 3 commits into from

Commits on Aug 7, 2020

  1. http2: allow Host in HTTP/2 requests

    The HTTP/2 spec allows Host to be used instead of :authority in
    requests, and this is in fact *preferred* when converting from HTTP/1.
    
    We erroneously treated Host as a connection header, thus disallowing
    it in requests. The patch corrects this, aligning Node.js behaviour
    with the HTTP/2 spec and with nghttp2:
    
     - Treat Host as a single-value header instead of a connection header.
     - Don't autofill :authority if Host is present.
     - The compatibility API (request.authority) falls back to using Host
       if :authority is not present.
    
    This is semver-major because requests are no longer guaranteed to
    have :authority set. An explanatory note was added to the docs.
    
    Fixes: nodejs#29858
    mildsunrise committed Aug 7, 2020
    Copy the full SHA
    014c725 View commit details
    Browse the repository at this point in the history
  2. typos

    mildsunrise committed Aug 7, 2020
    Copy the full SHA
    fe83df7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. improvements in docs

    mildsunrise committed Aug 11, 2020
    Copy the full SHA
    f96d134 View commit details
    Browse the repository at this point in the history