Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove ERR_INVALID_OPT_VALUE and ERR_INVALID_OPT_VALUE_ENCODING #34682

Closed
wants to merge 3 commits into from

Commits on Aug 18, 2020

  1. lib: remove ERR_INVALID_OPT_VALUE and ERR_INVALID_OPT_VALUE_ENCODING

    This will be a start to generalize all argument validation
    errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more
    specific errors.
    The OPT errors didn't bring much to the errors as it's just another
    variant of ARG error which is sometimes more confusing (some of our code
    used OPT errors to denote just argument validation errors presumably
    because of similarity of OPT to 'option' and not 'options-object')
    and they don't specify the name of the options object where the invalid
    value is located. Much better approach would be to just specify path
    to the invalid value in the name of the value as it is done in this PR
    (i.e. 'options.format', 'options.publicKey.type' etc)
    
    Also since this decreases a variety of errors we have it'd be easier to
    reuse validation code across the codebase.
    
    Refs: nodejs#31251
    Refs: nodejs#34070 (comment)
    Signed-off-by: Denys Otrishko <shishugi@gmail.com>
    lundibundi committed Aug 18, 2020
    Copy the full SHA
    e595e60 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. fixup! lib: remove ERR_INVALID_OPT_VALUE and ERR_INVALID_OPT_VALUE_EN…

    …CODING
    
    Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
    lundibundi and BridgeAR committed Aug 24, 2020
    Copy the full SHA
    d5fb345 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Copy the full SHA
    cdef566 View commit details
    Browse the repository at this point in the history