Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: benchmark script for resourceUsage #34691

Closed
wants to merge 1 commit into from
Closed

add: benchmark script for resourceUsage #34691

wants to merge 1 commit into from

Conversation

yashLadha
Copy link
Member

Added a benchmark script for process method to benchmark the method
resourceUsage.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@yashLadha
benchmark: add benchmark script for resourceUsage
90b305a 
Added a benchmark script for process method to benchmark the method
resourceUsage.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. process Issues and PRs related to the process subsystem. labels Aug 9, 2020
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 12, 2020 •
edited by rickyes

CI: https://ci.nodejs.org/job/node-test-pull-request/32743/ (💚)
Benchmarks: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/661/

@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 12, 2020
rickyes pushed a commit that referenced this pull request Aug 13, 2020
@yashLadha @rickyes
benchmark: add benchmark script for resourceUsage
56b25e7 
Added a benchmark script for process method to benchmark the method
resourceUsage.

PR-URL: #34691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@rickyes
Copy link
Contributor

rickyes commented Aug 13, 2020

Landed in 56b25e7

@rickyes rickyes closed this Aug 13, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@yashLadha @MylesBorins
benchmark: add benchmark script for resourceUsage
8f03bac 
Added a benchmark script for process method to benchmark the method
resourceUsage.

PR-URL: #34691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@yashLadha @BethGriggs
benchmark: add benchmark script for resourceUsage
8de6b72 
Added a benchmark script for process method to benchmark the method
resourceUsage.

PR-URL: #34691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@yashLadha @addaleax
benchmark: add benchmark script for resourceUsage
c709010 
Added a benchmark script for process method to benchmark the method
resourceUsage.

PR-URL: #34691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@yashLadha @addaleax
benchmark: add benchmark script for resourceUsage
24fddba 
Added a benchmark script for process method to benchmark the method
resourceUsage.

PR-URL: #34691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@mmarchini mmarchini mmarchini approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yashLadha @nodejs-github-bot @rickyes @jasnell @addaleax @mmarchini @BridgeAR