Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix message/esm_loader_not_found_cjs_hint_bare #34764

Closed
wants to merge 1 commit into from
Closed

test: fix message/esm_loader_not_found_cjs_hint_bare #34764

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Broken locally for me since f8976a7.

Refs: #34744

@guybedford @jasnell @jkrems Fyi

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax addaleax added test Issues and PRs related to the tests. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 13, 2020
@addaleax
Copy link
Member Author

Please 👍 this comment to approve fast-tracking (assuming it passes CI, not sure if it’s broken only for me locally?)

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32761/

@guybedford
Copy link
Contributor

This was a necessary fix to get the tests to pass, since packageResolve no longer exists under this refactoring. So I'm confused as to why this is necessary.

@guybedford
Copy link
Contributor

Let's see how the CI looks. Are you running a Mac?

richardlau
richardlau requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks CI.

@addaleax
Copy link
Member Author

Yeah, sorry. I’ll try to figure out what went wrong here, but it’s almost certainly something on my end. Oops!

@addaleax addaleax closed this Aug 13, 2020
@addaleax addaleax deleted the fix-resolve-test branch August 13, 2020 19:26
This was referenced Aug 15, 2020
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau requested changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@addaleax @nodejs-github-bot @guybedford @jasnell @richardlau