Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a fuzzer for LoadEnvironment #34844

Closed
wants to merge 5 commits into from
Closed

Adds a fuzzer for LoadEnvironment #34844

wants to merge 5 commits into from

Conversation

DavidKorczynski
Copy link
Contributor

Adds a new fuzzer to run under OSS-Fuzz. The main function that this fuzzer targets is node::LoadEnvironment.

The fuzzer is inspired by the cctest test case.

Cross-reference: #34761

Checklist

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 19, 2020
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2020
bnoordhuis
bnoordhuis reviewed Aug 19, 2020
View reviewed changes
test/fuzzers/fuzz_env.cc Outdated Show resolved Hide resolved
test/fuzzers/fuzz_env.cc Outdated Show resolved Hide resolved
test/fuzzers/fuzz_env.cc Outdated Show resolved Hide resolved
test/fuzzers/fuzz_env.cc Show resolved Hide resolved
test/fuzzers/fuzz_env.cc Outdated Show resolved Hide resolved
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32878/

joyeecheung
joyeecheung approved these changes Aug 21, 2020
View reviewed changes
test/fuzzers/fuzz_env.cc Show resolved Hide resolved
mhdawson
mhdawson approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidKorczynski
Copy link
Contributor Author

I was wondering if there is something in the PR I can help with in order to get this merged in?

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@mhdawson
Copy link
Member

mhdawson commented Oct 8, 2020

@DavidKorczynski just looks like somebody needs to land it. Have requested a new CI and will try to remember to do it tomorrow.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33481/

@mhdawson
Copy link
Member

mhdawson commented Oct 9, 2020

There was a failure in CI run but looks like an issue that has been reported before: #34730

@DavidKorczynski
Copy link
Contributor Author

The code in this PR is self-contained in that it doesn't influence other aspects of NodeJS except for the fuzzer itself. And the fuzzer is not run in automated tests but only by way of https://github.com/google/oss-fuzz

@mhdawson
Copy link
Member

mhdawson commented Oct 9, 2020 •
edited

Link to rebuild on OSX: https://ci.nodejs.org/job/node-test-pull-request/33493/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33493/

@mhdawson
Copy link
Member

mhdawson commented Oct 9, 2020

New CI was good. Landing

@DavidKorczynski
Copy link
Contributor Author

Thanks a lot @mhdawson

mhdawson pushed a commit that referenced this pull request Oct 9, 2020
@DavidKorczynski @mhdawson
build: fuzzer that targets node::LoadEnvironment()
de7a1ab 
Refs: #34761
Refs: #33724

PR-URL: #34844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

mhdawson commented Oct 9, 2020

Landed as de7a1ab

@mhdawson mhdawson closed this Oct 9, 2020
BethGriggs pushed a commit that referenced this pull request Oct 14, 2020
@DavidKorczynski @BethGriggs
build: fuzzer that targets node::LoadEnvironment()
9c74d45 
Refs: #34761
Refs: #33724

PR-URL: #34844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@DavidKorczynski @MylesBorins
build: fuzzer that targets node::LoadEnvironment()
2767dce 
Refs: #34761
Refs: #33724

PR-URL: #34844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@DavidKorczynski @MylesBorins
build: fuzzer that targets node::LoadEnvironment()
f3a0457 
Refs: #34761
Refs: #33724

PR-URL: #34844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@DavidKorczynski @joesepi
build: fuzzer that targets node::LoadEnvironment()
add2f26 
Refs: nodejs#34761
Refs: nodejs#33724

PR-URL: nodejs#34844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@DavidKorczynski @nodejs-github-bot @mhdawson @bnoordhuis @jasnell @addaleax @joyeecheung @richardlau