Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update module pages in CODEOWNERS #34932

Closed
wants to merge 1 commit into from
Closed

meta: update module pages in CODEOWNERS #34932

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 26, 2020

I figured that should explain why the bot didn't tag @nodejs/modules in #34875.

Maybe we could add a test to check if every file is listed to the CODEOWNERS to avoid it happening again?

I've also added /doc/api/packages.md, which will be introduced by #34748, it's probably a good idea to wait for it to land first before landing this PR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 26, 2020 •
edited by richardlau

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 26, 2020
@richardlau
Copy link
Member

I've also added /doc/api/packages.md, which will be introduced by #34748, it's probably a good idea to wait for it to land first before landing this PR.

This will be blocked until that lands as the linting for CODEOWNERS will fail for non-existent paths.

@mmarchini
Copy link
Contributor

Maybe we could add a test to check if every file is listed to the CODEOWNERS to avoid it happening again?

This is a good idea once we have all files listed (we're still very far today)

@richardlau richardlau added the blocked PRs that are blocked by other issues or PRs. label Aug 26, 2020
@aduh95
Copy link
Contributor Author

aduh95 commented Aug 29, 2020

@richardlau #34748 has landed, is there something I can do to unblock this PR?

@richardlau richardlau removed the blocked PRs that are blocked by other issues or PRs. label Aug 29, 2020
@richardlau
Copy link
Member

@richardlau #34748 has landed, is there something I can do to unblock this PR?

Rebase so that it’s picked up — that should get the lint-codeowners check to pass.

MylesBorins
MylesBorins approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Member

Landed in 622ea75

MylesBorins pushed a commit that referenced this pull request Aug 31, 2020
@aduh95 @MylesBorins
meta: update module pages in CODEOWNERS
622ea75 
PR-URL: #34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@aduh95 aduh95 deleted the patch-3 branch September 1, 2020 10:56
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 1, 2020

#34875 is not getting much love because @nodejs-github-bot didn't know who to tag. Can someone ping @nodejs/modules over there please?

@richardlau
Copy link
Member

This depends on #34748 (otherwise the CODEOWNER linting breaks) and that has the backport-blocked-v14.x, so I've added the same label here.

addaleax pushed a commit that referenced this pull request Sep 23, 2020
@aduh95 @addaleax
meta: update module pages in CODEOWNERS
d1be44c 
PR-URL: #34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
@aduh95 @MylesBorins
meta: update module pages in CODEOWNERS
ab7d0e9 
PR-URL: #34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@mmarchini mmarchini mmarchini approved these changes

@richardlau richardlau richardlau approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aduh95 @nodejs-github-bot @richardlau @mmarchini @MylesBorins @DerekNonGeneric @addaleax