Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update console.error example to API doc #34964

Closed
wants to merge 3 commits into from

Conversation

iyabong
Copy link
Contributor

@iyabong iyabong commented Aug 29, 2020

'console.error(new Error())' method
prints not only custom message but also stack trace.

So i added stack trace lines to example box.

Signed-off-by: Lee, Bonggi iyabong@gmail.com

Checklist

'console.error(new Error())' method
prints not only custom message but also stack trace.

So i added stack trace lines to example box.

Signed-off-by: Lee, Bonggi <iyabong@gmail.com>
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Aug 29, 2020
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋 Thanks for your work, that seems like a neat suggestion. Just a few comments:

doc/api/console.md Outdated Show resolved Hide resolved
doc/api/console.md Outdated Show resolved Hide resolved
iyabong and others added 2 commits October 24, 2020 14:30
remove OS specific console log

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
remove custom message

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Oct 24, 2020
aduh95 pushed a commit that referenced this pull request Oct 24, 2020
Signed-off-by: Lee, Bonggi <iyabong@gmail.com>

PR-URL: #34964
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@aduh95
Copy link
Contributor

aduh95 commented Oct 24, 2020

Landed in 440edaa, thanks again and congrats for your first commit in Node.js @iyabong!

@aduh95 aduh95 closed this Oct 24, 2020
targos pushed a commit that referenced this pull request Nov 3, 2020
Signed-off-by: Lee, Bonggi <iyabong@gmail.com>

PR-URL: #34964
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
Signed-off-by: Lee, Bonggi <iyabong@gmail.com>

PR-URL: #34964
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
Signed-off-by: Lee, Bonggi <iyabong@gmail.com>

PR-URL: #34964
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
Signed-off-by: Lee, Bonggi <iyabong@gmail.com>

PR-URL: #34964
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants