Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option --prof documentation help added #34991

Closed
wants to merge 2 commits into from
Closed

option --prof documentation help added #34991

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b790606
option --prof documentation help added
Krank2me Aug 30, 2020
1df2e1c
option --prof documentation help added
Krank2me Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/node_options.cc
View file
Open in desktop
Expand Up @@ -400,6 +400,9 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
"preserve symbolic links when resolving the main module",
&EnvironmentOptions::preserve_symlinks_main,
kAllowedInEnvironment);
AddOption("--prof",
+ "Generate V8 profiler output.",
+ &EnvironmentOptions::syntax_prof_only);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ "Generate V8 profiler output.",
+ &EnvironmentOptions::syntax_prof_only);
"Generate V8 profiler output.",
V8Option{});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @addaleax I added your suggested change but when I running test show the following error:

../src/node_options.cc:405:1: error: invalid argument type 'node::options_parser::OptionsParser<node::EnvironmentOptions>::V8Option' to unary expression V8Option{});

thanks for you help :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krank2me As you can see, the Github actions fail because this code currently doesn’t compile – if I apply the suggestion here, it passes locally for me.

If you are having trouble with this, it might be good if you could upload the relevant parts of the compile output somewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax you're right, thank you so much for you help :)

AddOption("--prof-process",
"process V8 profiler output generated using --prof",
&EnvironmentOptions::prof_process);
Expand Down