Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise AbortSignal text and example using events.once() #35005

Merged
merged 2 commits into from Sep 3, 2020
Merged

doc: revise AbortSignal text and example using events.once() #35005

merged 2 commits into from Sep 3, 2020

Commits on Sep 3, 2020

  1. doc: revise AbortSignal text and example using events.once() 

    Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Sep 3, 2020
    Copy the full SHA
    f9c362f View commit details
    Browse the repository at this point in the history

  2. doc: make AbortSignal text consistent in events.md 

    Further minor modifications to AbortSignal text in events.md for
consistency.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @Trott
    Trott committed Sep 3, 2020
    Copy the full SHA
    cc754f2 View commit details
    Browse the repository at this point in the history