v14.10.0 proposal #35023
Merged
v14.10.0 proposal #35023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic support doesn't exist prior to Node.js 15 and is unlikely to due to requiring patches on top of openssl. Remove the entries from CODEOWNERS to fix the CODEOWNERS linting, which currently fails as it refers to non-existent paths. PR-URL: #34947 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Avoid repeating too much from the Microsoft guide by providing links to it. PR-URL: #34871 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #34881 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/above PR-URL: #34877 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This adds a new make target to generate platform dependent files for openssl on non-linux machines. The scripts we currently have in place require linux. This adds a Dockerfile that installs the necessary dependencies to be able to generate these files. Previously, it was necessary to run `make -C deps/openssl/config` on a linux machine. Now, as long as docker is installed and in your `PATH`, it is possible to run `make gen-openssl`. PR-URL: #34642 Reviewed-By: James M Snell <jasnell@gmail.com>
This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in openssl/openssl#12369 to generate the required files. PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Ref: nodejs/TSC#886 Ref: #34043 PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
PR-URL: #34889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The `<` character is interpreted as the start of an HTML tag, making the word `address` not render and the rest of the document rendered with a grey background and in italics. Use `<` instead. PR-URL: #34892 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Minor improvements. PR-URL: #34868 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: #34893 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #34879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34880 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34552 Reviewed-By: James M Snell <jasnell@gmail.com>
Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: #34910 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34909 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #34923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* Avoid passing core `void*` and function pointers into add-on. * Document `napi_async_cleanup_hook_handle` type. * Render receipt of the handle mandatory from the point where the hook gets called. Removal of the handle remains mandatory. Fixes: #34715 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: #34819 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #34926 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Refs: https://github.com/google/brotli/releases/tag/v1.0.8 Refs: https://github.com/google/brotli/releases/tag/v1.0.9 PR-URL: #34937 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #34943 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Use uv_metrics_idle_time() to return a high resolution millisecond timer of the amount of time the event loop has been idle since it was initialized. Include performance.eventLoopUtilization() API to handle the math of calculating the idle and active times. This has been added to prevent accidental miscalculations of the event loop utilization. Such as not taking into consideration offsetting nodeTiming.loopStart or timing differences when being called from a Worker thread. PR-URL: #34938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #34929 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Start up a TLS server on localhost rather than using example.org. PR-URL: #34953 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: #35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Inline a function that only gets called in the constructor. Make call to `super()` more straightforward in the process by removing conditional involving the function as it only ever returns `undefined` or else throws. That made the code a little hard to understand, as without looking at the function, one would likely expect it to return `true` on success rather than `undefined`. PR-URL: #35064 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Present tense should be default choice. It is usually easier to read and understand. Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs PR-URL: #35068 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Useful for future PR's to resolve situations where e.g. finished() is invoked on an already errored streams. PR-URL: #34103 Backport-PR-URL: #34887 Refs: #34680 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) #34960 - crypto: add randomInt function (Oli Lalonde) #34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) #34938 - stream: simpler and faster Readable async iterator (Robert Nagy) #34035 - stream: save error in state (Robert Nagy) #34103 PR-URL: #35023
richardlau
force-pushed
the
v14.10.0-proposal
branch
from
9596719
to
ce5f587
Compare
Not shown here is that The The |
BethGriggs
approved these changes
Sep 8, 2020
|
Were there new failures in 14.9 on Citgm? I don't recognize the browserify failures for example |
|
@MylesBorins, just briefly dug into the Browserify failures. It seems to be occurring as far back as v14.0.0 and also on v12.x. |
richardlau
added a commit
that referenced
this pull request
Sep 8, 2020
Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) #34960 - crypto: add randomInt function (Oli Lalonde) #34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) #34938 - stream: simpler and faster Readable async iterator (Robert Nagy) #34035 - stream: save error in state (Robert Nagy) #34103 PR-URL: #35023 Conflicts: src/node_version.h
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Sep 8, 2020
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 8, 2020
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) nodejs#34960 - crypto: add randomInt function (Oli Lalonde) nodejs#34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) nodejs#34938 - stream: simpler and faster Readable async iterator (Robert Nagy) nodejs#34035 - stream: save error in state (Robert Nagy) nodejs#34103 PR-URL: nodejs#35023 Conflicts: src/node_version.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-09-08, Version 14.10.0 (Current), @richardlau
Notable Changes
2ab33c58ae] - (SEMVER-MINOR) buffer: also alias BigUInt methods (Anna Henningsen) #3496044d89a9faa] - (SEMVER-MINOR) crypto: add randomInt function (Oli Lalonde) #346008aac42caf2] - (SEMVER-MINOR) perf_hooks: add idleTime and event loop util (Trevor Norris) #349384bb40078da] - (SEMVER-MINOR) stream: simpler and faster Readable async iterator (Robert Nagy) #34035ffae5f3809] - (SEMVER-MINOR) stream: save error in state (Robert Nagy) #34103Commits
1fdfaa578f] - bootstrap: correct --frozen-intrinsics override fix (Guy Bedford) #350412ab33c58ae] - (SEMVER-MINOR) buffer: also alias BigUInt methods (Anna Henningsen) #349601be6956ee0] - build: require "allow edits" to be checked (Jordan Harband) #350027b7299012e] - build: comment about auto close when stalled via with github action (Phillip Johnsen) #34555d6c796b4ab] - build: close stalled issues and PRs with github action (Phillip Johnsen) #3455546766a10df] - build: use autorebase option for git node land (Denys Otrishko) #349697afb67f491] - build: use latest node-core-utils from npm (Denys Otrishko) #34969d06e158253] - build: add support for build on arm64 (Evan Lucas) #34238755f9e4bc8] - build,deps: add gen-openssl target (Evan Lucas) #34642178a740caf] - crypto: simplify KeyObject constructor (Rich Trott) #35064a12d92c97b] - crypto: fix randomInt range check (Tobias Nießen) #350526d0d5b2ec2] - crypto: align parameter names with documentation (Rich Trott) #3505444d89a9faa] - (SEMVER-MINOR) crypto: add randomInt function (Oli Lalonde) #34600791a85b880] - deps: V8: cherry-pick 6be2f6e26e8d (Benjamin Coe) #3505596ae05a770] - deps: V8: backport 3f071e3e7e15 (Milad Farazmand) #3503690f9348297] - deps: update brotli to v1.0.9 (Anna Henningsen) #34937f1fcd6646d] - deps: add openssl support for arm64 (Evan Lucas) #34238bbf7b925a2] - doc: use present tense in events.md (Rich Trott) #35068f6b2286e12] - doc: change stablility-2 color for accessibility (Rich Trott) #350618044533e87] - doc: add link to safe integer definition (Tobias Nießen) #35049f03a4d78a2] - doc: format exponents better (Tobias Nießen) #350501a9ca52716] - doc: add ESM examples inmoduleAPI doc page (Antoine du HAMEL) #348750ac7d5423f] - doc: add deprecated badge to legacy URL methods (Antoine du HAMEL) #34931a08e853edc] - doc: spruce up user journey to local docs browsing (Derek Lewis) #3498683a3e3b681] - doc: update syntax highlighting color for accessibility (Rich Trott) #350635bd0e0803d] - doc: fix incorrect URL in cli.md (Rich Trott) #3504328e89f6766] - doc: remove style for empty links (Antoine du HAMEL) #35034cdc1198a62] - doc: fix certificate display in tls doc (Rich Trott) #3503272d03cd802] - doc: remove duplicate error code entry (Rich Trott) #35031680782ea64] - doc: use consistent header typography (Rich Trott) #350301ae674c67a] - doc: fix malformed hashes in assert.md (Rich Trott) #35028c3a3cb69aa] - doc: fix a typo of microtaskMode (Shigma) #34980a846a9f116] - doc: change 'be will' to 'will be' (Victory Osikwemhe) #34999593236ad33] - doc: change color contrast for accessibility (Rich Trott) #350478c207c67d1] - doc: refactor deprecation anchors (Antoine du HAMEL) #34955cc0aaf2384] - doc: error code fix in resolver spec (Guy Bedford) #34998a4201843e7] - doc: use period consistently in man page (Rich Trott) #34939f1217d6d8b] - doc: revise commit-queue.md (Rich Trott) #350069aba579acb] - doc: change effected to affected (Turner Jabbour) #349892598527112] - doc: drop the --production flag for installing windows-build-tools (DeeDeeG) #34979287ce7b810] - doc: fix broken link to response.writableFinished in deprecations doc (Rich Trott) #34983a0656ff863] - doc: fix broken link to response.finished in deprecations doc (Rich Trott) #34982f4524b8936] - doc: fix broken link to writableEnded in deprecations doc (Rich Trott) #34984514a538f64] - doc: fix typos in buffer doc (Robert Williams) #34981df76c89b78] - doc: recommend URL() over url.parse() in http2 doc (Rich Trott) #34978ca0302e4f1] - doc: arrange perf_hooks entries alphabetically (Rich Trott) #3497394c6e09367] - doc: replace require() with reference links in http2.md (Rich Trott) #349562407a7a671] - doc: add a note about possible missing lines to readline.asyncIterator (Igor Mikhalev) #3467531098a4c0e] - doc: make minor improvements to query string sentence in http2.md (Rich Trott) #349291589f0e6f4] - doc: make general copy-edit changes to policy.md (Rich Trott) #34943aee3b8510b] - doc: simplify "make use of" to "use" (Rich Trott) #348610e09ff8ab1] - doc: make minor fixes to maintaining-openssl.md (Rich Trott) #34926b091681d25] - doc: fix CHANGELOG.md parsing issue (Juan José Arboleda) #34923fbd18be459] - doc: provide more guidance about process.version (Rich Trott) #349094782ec7b3b] - doc: use consistent typography for node-addon-api (Rich Trott) #349102fe95094fd] - doc: improve link-local text in dgram.md (Rich Trott) #34868657292e2dd] - doc: fix broken markdown/display in cli.html (Rich Trott) #348924cf93bb3cf] - doc: use "previous"/"preceding" instead of "above" as modifier (Rich Trott) #3487729b048b06b] - doc: use links to MS guide in style guide (Rich Trott) #3487152be37cf39] - doc,tools: remove malfunctioning Linux manpage linker (Rich Trott) #34985fffba3a270] - errors: useErrorPrototypeToStringfromprimordialsobject (ExE Boss) #34891db8c66b8c2] - esm: shorten ERR_UNSUPPORTED_ESM_URL_SCHEME message (Rich Trott) #34836be71e717c5] - meta: enable wasi for CODEOWNERS (gengjiawen) #34889a43b7ff72e] - meta: remove non-existent quic from CODEOWNERS (Richard Lau) #349473c32fe09e9] - n-api: re-implement async env cleanup hooks (Gabriel Schulhof) #34819fcb211f38a] - net: replace usage of internal stream state with public api (Denys Otrishko) #348858aac42caf2] - (SEMVER-MINOR) perf_hooks: add idleTime and event loop util (Trevor Norris) #3493818b04ab4c8] - policy: implement scopes field (Bradley Farias) #345521bf5d1a39b] - querystring: manage percent character at unescape (Daijiro Wachi) #35013f21d78d537] - src: shutdown libuv before exit() (Anna Henningsen) #35021789798bedf] - src: add get/set pair for env context awareness (Shelley Vohr) #3502473ef3f2f05] - src: disallow JS execution during exit() (Anna Henningsen) #35020f6a5999a9d] - src,doc: fix wording to refer to context, not environment (Turner Jabbour) #34880bcc1d431f8] - src,doc: fix grammar due to missing 'is' (Turner Jabbour) #34897044297ff10] - src,doc: rephrase for clarity (Turner Jabbour) #348794bb40078da] - (SEMVER-MINOR) stream: simpler and faster Readable async iterator (Robert Nagy) #34035ffae5f3809] - (SEMVER-MINOR) stream: save error in state (Robert Nagy) #341035f24cea11a] - stream: fix Readable stream state properties (Denys Otrishko) #34886f537c868b9] - stream: allow using.push()/.unshift()duringonce('data')(Anna Henningsen) #349574d533858cf] - test: make .out checks embedder-friendly (Shelley Vohr) #35040a756b92c4a] - test: use mustCall() in test-http-timeout (Pooja D.P) #349969011c87c1c] - test: change var to let (Pooja D.P) #34902b698d2ec81] - test: remove incorrect debug() in test-policy-integrity (Rich Trott) #34961ee6a583b9f] - test: fix typo in test/parallel/test-icu-punycode.js (Daijiro Wachi) #349349057a1644d] - test: add readline test for escape sequence (Rich Trott) #3495275d16125e1] - test: make test-tls-reuse-host-from-socket pass without internet (Rich Trott) #34953971b7ac087] - test: simplify test-vm-memleak (Rich Trott) #34881577978a96c] - tools: fix docopen target (Antoine du HAMEL) #350622b445bb3ee] - tools: fix doc build targets (Antoine du HAMEL) #350603d41ff25b7] - tools: add banner to lint-md.js by rollup.config.js (KuthorX) #3423362cc3b8249] - tools: update ESLint to 7.8.1 (cjihrig) #35004c47d319ac6] - tools: update ESLint to 7.8.0 (cjihrig) #35004b6f3ae8ffc] - tools,doc: allow page titles to contain inline code (Antoine du HAMEL) #35003fb2111e300] - tools,doc: fix global table of content active element (Antoine du Hamel) #349767ad629e4e4] - tools,doc: remove "toc" anchor name (Rich Trott) #3489394528f510e] - zlib: replace usage of internal stream state with public api (Denys Otrishko) #34884cc @nodejs/release
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes