Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 6be2f6e26e8d #35055

Merged
merged 1 commit into from Sep 6, 2020
Merged

Commits on Sep 6, 2020

  1. deps: V8: cherry-pick 6be2f6e26e8d

    Original commit message:
    
        [coverage] IncBlockCounter should not be side-effect
    
        Incrementing coverage counter was triggering EvalError for
        evaluateOnCallFrame when throwOnSideEffect is true.
    
        R=jgruber@chromium.org, sigurds@chromium.org, yangguo@chromium.org
    
        Bug: v8:10856
        Change-Id: I0552e19a3a14ff61a9cb626494fb4a21979d535e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2384011
        Commit-Queue: Benjamin Coe <bencoe@google.com>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69628}
    
    Refs: v8/v8@6be2f6e
    
    PR-URL: nodejs#35055
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bcoe authored and Trott committed Sep 6, 2020
    Copy the full SHA
    6d9a316 View commit details
    Browse the repository at this point in the history