Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix comment about DNS lookup test #35080

Merged
merged 1 commit into from Sep 9, 2020
Merged

test: fix comment about DNS lookup test #35080

merged 1 commit into from Sep 9, 2020

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Sep 6, 2020 •
edited

This comment has been there for about 10.5 years (see f13e2f9), but I don't think it has ever been an accurate description of the test. (Unless I am missing something, of course.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessen tniessen added dns Issues and PRs related to the dns subsystem. test Issues and PRs related to the tests. labels Sep 6, 2020
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33094/

@tniessen @Trott
test: fix comment about DNS lookup test
1204400 
PR-URL: nodejs#35080
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 9, 2020

Landed in 1204400

@Trott Trott merged commit 1204400 into nodejs:master Sep 9, 2020
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
@tniessen @ruyadorno
test: fix comment about DNS lookup test
bc38485 
PR-URL: #35080
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@tniessen @MylesBorins
test: fix comment about DNS lookup test
5691dfd 
PR-URL: #35080
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@tniessen @MylesBorins
test: fix comment about DNS lookup test
607f3c5 
PR-URL: #35080
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@tniessen @joesepi
test: fix comment about DNS lookup test
7b75cde 
PR-URL: nodejs#35080
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tniessen @nodejs-github-bot @Trott @addaleax @lpinca @cjihrig