Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: simplify ERR_REQUIRE_ESM message generation #35123

Merged
merged 1 commit into from Sep 11, 2020
Merged

errors: simplify ERR_REQUIRE_ESM message generation #35123

merged 1 commit into from Sep 11, 2020

Commits on Sep 11, 2020

  1. errors: simplify ERR_REQUIRE_ESM message generation 

    Because of the condition that starts the `if` block, we know that
`parentPath` must be truthy. So there is no need to check for that in
the template string that generates the error message.

PR-URL: nodejs#35123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
    @Trott
    Trott committed Sep 11, 2020
    Copy the full SHA
    f54254a View commit details
    Browse the repository at this point in the history