Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] V8: cherry-pick 71736859756b2bd0444bdb0a87a #35205

Closed
wants to merge 4 commits into from
Closed

[deps] V8: cherry-pick 71736859756b2bd0444bdb0a87a #35205

wants to merge 4 commits into from

Commits on Sep 23, 2020

  1. [deps] V8: cherry-pick 71736859756b2bd0444bdb0a87a 

    Original commit message:

   [heap] Add large_object_threshold to AllocateRaw

   This commit adds a check in Heap::AllocateRaw when setting the
   large_object variable, when the AllocationType is of type kCode, to
   take into account the size of the CodeSpace's area size.

   The motivation for this change is that without this check it is
   possible that size_in_bytes is less than 128, and hence not considered
   a large object, but it might be larger than the available space
   in code_space->AreaSize(), which will cause the object to be created
   in the CodeLargeObjectSpace. This will later cause a segmentation fault
   when calling the following chain of functions:

      if (!large_object) {
         MemoryChunk::FromHeapObject(heap_object)
             ->GetCodeObjectRegistry()
             ->RegisterNewlyAllocatedCodeObject(heap_object.address());
      }

   We (Red Hat) ran into this issue when running Node.js v12.16.1 in
   combination with yarn on aarch64 (this was the only architecture that
   this happed on).

   Bug: v8:10808
   Change-Id: I0c396b0eb64bc4cc91d9a3be521254f3130eac7b
   Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390665
   Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
   Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#69876}

Refs: v8/v8@7173685
    @danbev
    danbev committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    a8287fe View commit details
    Browse the repository at this point in the history

  2. squash: use ToObjectChecked instead of ToAddress()

    @danbev
    danbev committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    5c214a3 View commit details
    Browse the repository at this point in the history

  3. squash: use ToObjectChecked in CreateFillerObjectAt

    @danbev
    danbev committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    11a0593 View commit details
    Browse the repository at this point in the history

  4. squash: use AllocationAlignment::KWordAligned

    @danbev
    danbev committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    b02c563 View commit details
    Browse the repository at this point in the history