Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win, child_process: sanitize env variables #35210

Closed
wants to merge 1 commit into from
Closed

win, child_process: sanitize env variables #35210

wants to merge 1 commit into from

Commits on Sep 24, 2020

  1. win, child_process: sanitize env variables 

    On Windows environment variables are case-insensitive. When spawning
child process certain apps can get confused if some of the variables are
duplicated.

This adds a step on Windows to normalizeSpawnArguments that removes such
duplicates, keeping only the first (in lexicographic order) entry in the
env key of options. This is partly already done for the PATH entry.

Fixes: nodejs#35129
    @bzoz
    bzoz committed Sep 24, 2020
    Copy the full SHA
    2df8258 View commit details
    Browse the repository at this point in the history