Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: add more property defaults #35214

Closed
wants to merge 4 commits into from
Closed

n-api: add more property defaults #35214

wants to merge 4 commits into from

Commits on Sep 15, 2020

  1. n-api: add more property defaults 

    Add a default value for class method and js like property in enum
napi_property_attributes.

n-api currently offers only one default which is non configurable,
non writable, non enumerable - like Object.defineProperty(). While
this is formal correct the usual way to create properties in JS is
either by defining a class or use obj.prop = value.

The defaults from these variants are now backed into enum values.
    @Flarna
    Flarna committed Sep 15, 2020
    Copy the full SHA
    c6ccd8a View commit details
    Browse the repository at this point in the history

  2. add changes section

    @Flarna
    Flarna committed Sep 15, 2020
    Copy the full SHA
    0d3f7c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. remove some doc changes, add experimental

    @Flarna
    Flarna committed Sep 16, 2020
    Copy the full SHA
    6728bf1 View commit details
    Browse the repository at this point in the history

  2. Update src/js_native_api_types.h 

    Co-authored-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
    @Flarna @gabrielschulhof
    Flarna and gabrielschulhof committed Sep 16, 2020
    Copy the full SHA
    caac675 View commit details
    Browse the repository at this point in the history