Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ignore build folder when checking links #35315

Closed
wants to merge 1 commit into from

Conversation

AshCripps
Copy link
Member

We checkout build as a subdirectory as part of CI and
if you run make test instead of make test-ci you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 23, 2020
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally keep the names checked in alphabetical order.

@AshCripps
Copy link
Member Author

Optionally keep the names checked in alphabetical order.

Ah didn't spot they were in alphabetical order will change that

We checkout build as a subdirectory as part of CI and
if you run `make test` instead of `make test-ci` you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 23, 2020
@Trott
Copy link
Member

Trott commented Sep 23, 2020

Fast-track?

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2020
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 23, 2020
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/35315
✔  Done loading data for nodejs/node/pull/35315
----------------------------------- PR info ------------------------------------
Title      tools: ignore build folder when checking links (#35315)
Author     Ash Cripps  (@AshCripps)
Branch     AshCripps:ignore-build -> nodejs:master
Labels     author ready, doc, fast-track, tools
Commits    1
 - tools: ignore build folder when checking links
Committers 1
 - Ash Cripps 
PR-URL: https://github.com/nodejs/node/pull/35315
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35315
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2020-09-23T11:36:52Z: https://ci.nodejs.org/job/node-test-pull-request/33210/
- Querying data for job/node-test-pull-request/33210/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Wed, 23 Sep 2020 10:54:46 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35315#pullrequestreview-494545968
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35315#pullrequestreview-494551596
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35315#pullrequestreview-494643274
   ℹ  This PR is being fast-tracked
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 24, 2020
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 24, 2020
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 24, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/35315
✔  Done loading data for nodejs/node/pull/35315
----------------------------------- PR info ------------------------------------
Title      tools: ignore build folder when checking links (#35315)
Author     Ash Cripps  (@AshCripps)
Branch     AshCripps:ignore-build -> nodejs:master
Labels     author ready, doc, fast-track, tools
Commits    1
 - tools: ignore build folder when checking links
Committers 1
 - Ash Cripps 
PR-URL: https://github.com/nodejs/node/pull/35315
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35315
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2020-09-24T09:23:04Z: https://ci.nodejs.org/job/node-test-pull-request/33210/
- Querying data for job/node-test-pull-request/33210/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
   ℹ  This PR was created on Wed, 23 Sep 2020 10:54:46 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35315#pullrequestreview-494545968
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35315#pullrequestreview-494551596
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35315#pullrequestreview-494643274
   ℹ  This PR is being fast-tracked
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 24, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2020
@github-actions
Copy link
Contributor

Landed in 77dd440

@github-actions github-actions bot closed this Sep 24, 2020
nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2020
We checkout build as a subdirectory as part of CI and
if you run `make test` instead of `make test-ci` you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo

PR-URL: #35315
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
We checkout build as a subdirectory as part of CI and
if you run `make test` instead of `make test-ci` you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo

PR-URL: #35315
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
We checkout build as a subdirectory as part of CI and
if you run `make test` instead of `make test-ci` you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo

PR-URL: #35315
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
We checkout build as a subdirectory as part of CI and
if you run `make test` instead of `make test-ci` you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo

PR-URL: #35315
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
We checkout build as a subdirectory as part of CI and
if you run `make test` instead of `make test-ci` you get
loads of errors about markdown link breaks. Ignore this
directory as we don't need to examine another repo

PR-URL: nodejs#35315
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants