Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update wpt tests for url #35329

Closed
wants to merge 1 commit into from
Closed

test: update wpt tests for url #35329

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Sep 24, 2020

Refs: web-platform-tests/wpt#25086

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 24, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33256/

watilde added a commit that referenced this pull request Sep 27, 2020
@watilde
test: update wpt tests for url
589dbf1 
Refs: web-platform-tests/wpt#25086

PR-URL: #35329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde
Copy link
Member Author

watilde commented Sep 27, 2020

Landed in 589dbf1

@watilde watilde closed this Sep 27, 2020
@watilde watilde deleted the feat/wpt-updates branch September 27, 2020 15:37
@watilde
Copy link
Member Author

watilde commented Sep 28, 2020

Put dont-land-on-v14.x because this patch is depending on #33770

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@watilde @joesepi
test: update wpt tests for url
d35f7e6 
Refs: web-platform-tests/wpt#25086

PR-URL: nodejs#35329
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@Leko Leko Leko approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@watilde @nodejs-github-bot @Trott @Leko @lpinca