Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update wpt status for url #35335

Closed
wants to merge 1 commit into from
Closed

test: update wpt status for url #35335

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Sep 25, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 25, 2020
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33258/

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33264/

@watilde
Copy link
Member Author

watilde commented Sep 28, 2020

The latest ci result seems to be green: https://ci.nodejs.org/job/node-test-pull-request/33264/

watilde added a commit that referenced this pull request Sep 28, 2020
@watilde
test: update wpt status for url
c88d845 
PR-URL: #35335
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watilde
Copy link
Member Author

watilde commented Sep 28, 2020

Landed in c88d845

@watilde watilde closed this Sep 28, 2020
@watilde watilde deleted the test/url branch September 28, 2020 03:58
@watilde
Copy link
Member Author

watilde commented Sep 28, 2020

Put dont-land-on-v14.x because this patch is depending on #33770

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@watilde @joesepi
test: update wpt status for url
9c143d7 
PR-URL: nodejs#35335
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@Leko Leko Leko approved these changes

@targos targos targos approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@watilde @nodejs-github-bot @Trott @Leko @targos @crypt096