Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Revert refine conditions constraints PR #35357

Closed

Conversation

guybedford
Copy link
Contributor

This reverts the PR #35311 which landed before the 7 day limit required for PRs with one approval.

This was a misinterpretation from my side of the previous relaxation of the waiting period, which I thought had also been applied to these cases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 26, 2020
@Trott
Copy link
Member

Trott commented Sep 26, 2020

I'd prefer we leave it rather than revert. It's a doc change. If someone doesn't like it, they can change it again....

@guybedford
Copy link
Contributor Author

I'm happy either way here and apologies for the mix up.

@Trott
Copy link
Member

Trott commented Sep 26, 2020

I'm going to optimistically close this, but any other collaborator who feels differently should absolutely feel free to mash the "re-open" button.

@Trott Trott closed this Sep 26, 2020
@guybedford
Copy link
Contributor Author

That seems a safe assessment to me. There was modules repo discussion on this topic that led to suggestions for the original PR. There were no complaints raised in that discussion for this approach and I don't know of any arguments against the changes in the PR - it was a fairly uncontroversial one I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants