Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: use "node:" internal namespace for builtins #35387

Closed
wants to merge 5 commits into from
Closed

esm: use "node:" internal namespace for builtins #35387

wants to merge 5 commits into from

Commits on Sep 28, 2020

  1. esm: use "node:" namespace for builtins

    @guybedford
    guybedford committed Sep 28, 2020
    Copy the full SHA
    f12b025 View commit details
    Browse the repository at this point in the history

  2. fixup unknown builtin test and error

    @guybedford
    guybedford committed Sep 28, 2020
    Copy the full SHA
    e85f1f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @guybedford @aduh95
    guybedford and aduh95 committed Sep 29, 2020
    Copy the full SHA
    96cee98 View commit details
    Browse the repository at this point in the history

  2. include startswith definition

    @guybedford
    guybedford committed Sep 29, 2020
    Copy the full SHA
    226320e View commit details
    Browse the repository at this point in the history

  3. also include StringPrototypeSlice

    @guybedford
    guybedford committed Sep 29, 2020
    Copy the full SHA
    3d48169 View commit details
    Browse the repository at this point in the history