Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] test: add arrayOfStreams to pipeline #35388

Closed
wants to merge 1 commit into from
Closed

[v12.x] test: add arrayOfStreams to pipeline #35388

wants to merge 1 commit into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Sep 28, 2020

Back port to v12.x staging.

PR-URL: #34156
Reviewed-By: @ronag
Reviewed-By: @mcollina
Reviewed-By: @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@rickyes
test: add arrayOfStreams to pipeline
dba0a8d 
PR-URL: nodejs#34156
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v12.x labels Sep 28, 2020
@rickyes rickyes mentioned this pull request Sep 28, 2020
Closed
2 tasks
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33271/

mcollina
mcollina approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax
Copy link
Member

Landed in 52627bcd6a3488beef9c413a3911acbd89eb7559

@addaleax addaleax closed this Sep 28, 2020
@rickyes rickyes deleted the backport-34156-to-v12.x branch September 28, 2020 08:59
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@rickyes @addaleax
test: add arrayOfStreams to pipeline
2f67e99 
PR-URL: #34156
Backport-PR-URL: #35388
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rickyes @nodejs-github-bot @addaleax @mcollina