Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x backport] repl: support --loader option in builtin REPL #35394

Closed
wants to merge 2 commits into from
Closed

[v12.x backport] repl: support --loader option in builtin REPL #35394

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 28, 2020

Backport of #33437

First commit is a cherry-pick of 05539c1 with simple conflicts solved.
I added a fixup commit to avoid printing the experimental warning everytime the REPL is started. There is one difference with the current state of v12.x though: if we merge this, using dynamic import from within the REPL will no longer print the warning, because the ESM loader will already be initialized.

/cc @nodejs/modules

@targos
repl: support --loader option in builtin REPL
ee7cae2 
Fixes: nodejs#33435

PR-URL: nodejs#33437
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
fixup! repl: support --loader option in builtin REPL
43da6c8
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. v12.x labels Sep 28, 2020
@targos targos added esm Issues and PRs related to the ECMAScript Modules implementation. repl Issues and PRs related to the REPL subsystem. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33276/

@addaleax
Copy link
Member

Landed in b7be751

@addaleax addaleax closed this Sep 28, 2020
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@targos @addaleax
repl: support --loader option in builtin REPL
b7be751 
Fixes: #33435

PR-URL: #33437
Backport-PR-URL: #35394
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos deleted the repl-loader-v12.x branch September 28, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@targos @nodejs-github-bot @addaleax