Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 8.6 #35415

Closed
wants to merge 25 commits into from
Closed

deps: update V8 to 8.6 #35415

wants to merge 25 commits into from

Commits on Oct 17, 2020

  1. deps: update V8 to 8.6.395

    targos committed Oct 17, 2020
    Copy the full SHA
    05c8ef8 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a57e39a View commit details
    Browse the repository at this point in the history
  3. src: update NODE_MODULE_VERSION to 88

    Major V8 updates are usually API/ABI incompatible with previous
    versions. This commit adapts NODE_MODULE_VERSION for V8 8.6.
    
    Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    targos committed Oct 17, 2020
    Copy the full SHA
    973e411 View commit details
    Browse the repository at this point in the history
  4. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Oct 17, 2020
    Copy the full SHA
    44b5689 View commit details
    Browse the repository at this point in the history
  5. deps: patch V8 to run on older XCode versions

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
    property, which is a fairly new C++ feature, since that requires a newer
    XCode version than the minimum requirement in BUILDING.md and thus
    breaks CI.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ryzokuken authored and targos committed Oct 17, 2020
    Copy the full SHA
    225ebf5 View commit details
    Browse the repository at this point in the history
  6. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Oct 17, 2020
    Copy the full SHA
    d7a9747 View commit details
    Browse the repository at this point in the history
  7. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Oct 17, 2020
    Copy the full SHA
    96c79fa View commit details
    Browse the repository at this point in the history
  8. deps: make v8.h compatible with VS2015

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joaocgreis authored and targos committed Oct 17, 2020
    Copy the full SHA
    d92466a View commit details
    Browse the repository at this point in the history
  9. deps: V8: silence irrelevant warnings

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed Oct 17, 2020
    Copy the full SHA
    e04e842 View commit details
    Browse the repository at this point in the history
  10. deps: patch V8 to run on Xcode 8

    Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
    passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
    'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
    returning from a function (which is likely a bug on Xcode, considering
    this worked on the prior version of Xcode as well as newer versions).
    This workaround shouldn't affect the application, since the const
    qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
    
    There's also a V8 test passing a const-qualified type to ::Of, but since
    we don't test V8 on Xcode 8, it should be fine to leave it as is.
    
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini authored and targos committed Oct 17, 2020
    Copy the full SHA
    474690c View commit details
    Browse the repository at this point in the history
  11. deps: update V8 postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script
    to fix SmartOS compilation for V8 8.4.
    
    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    cjihrig authored and targos committed Oct 17, 2020
    Copy the full SHA
    8d57783 View commit details
    Browse the repository at this point in the history
  12. deps: update V8 postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script to
    fix SmartOS compilation with V8 8.5.
    cjihrig authored and targos committed Oct 17, 2020
    Copy the full SHA
    b234368 View commit details
    Browse the repository at this point in the history
  13. Copy the full SHA
    e3c8ba9 View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    8f6c837 View commit details
    Browse the repository at this point in the history
  15. deps: V8: cherry-pick 6be2f6e26e8d

    Original commit message:
    
        [coverage] IncBlockCounter should not be side-effect
    
        Incrementing coverage counter was triggering EvalError for
        evaluateOnCallFrame when throwOnSideEffect is true.
    
        R=jgruber@chromium.org, sigurds@chromium.org, yangguo@chromium.org
    
        Bug: v8:10856
        Change-Id: I0552e19a3a14ff61a9cb626494fb4a21979d535e
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2384011
        Commit-Queue: Benjamin Coe <bencoe@google.com>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#69628}
    
    Refs: v8/v8@6be2f6e
    targos committed Oct 17, 2020
    Copy the full SHA
    956f949 View commit details
    Browse the repository at this point in the history
  16. deps: V8: cherry-pick 717543bbf0ef

    Original commit message:
    
        [zone]: fix build on msvc in wasm module
    
        Fix: nodejs/node-v8#172
        Change-Id: Ibdbee76470ec8a4c20af7650dc5fac4602873430
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414688
        Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70109}
    
    Refs: v8/v8@717543b
    targos committed Oct 17, 2020
    Copy the full SHA
    3c11c7e View commit details
    Browse the repository at this point in the history
  17. deps: V8: cherry-pick d76abfed3512

    Original commit message:
    
        [wasm-simd][arm64] fix cross compile arm64 on windows
    
        See: nodejs#35415
        Change-Id: I5d77ae202d4bbfb0971246fe5de9c0ad17c485ff
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2459491
        Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
        Auto-Submit: Jiawen Geng <technicalcute@gmail.com>
        Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70444}
    
    Refs: v8/v8@d76abfe
    targos committed Oct 17, 2020
    Copy the full SHA
    8e7f284 View commit details
    Browse the repository at this point in the history
  18. deps: V8: cherry-pick 3176bfd447a9

    Original commit message:
    
        [heap-profiler] Fix crash when a snapshot deleted while taking one
    
        Fix a crash/hang that occurred when deleting a snapshot during the
        GC that is part of taking another one.
    
        Specifically, when deleting the only other snapshot in such
        a situation, the `v8::HeapSnapshot::Delete()` method sees that there
        is only one (complete) snapshot at that point, and decides that it is
        okay to perform “delete all snapshots” instead of just deleting
        the requested one. That resets the internal string lookup table
        of the heap profiler, but the new snapshot that is currently in
        progress still holds references to the old string lookup table,
        leading to a use-after-free segfault or infinite loop.
    
        Fix this by guarding against resetting the string table while
        another heap snapshot is being taken, and add a test that would
        crash before this fix.
    
        This can be triggered in Node.js by repeatedly calling
        `v8.getHeapSnapshot()`, which provides heap snapshots as weakly
        held host objects.
    
        Change-Id: If9ac3728bf79114000982f1e7bb05e8034299e3c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464823
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#70445}
    
    Refs: v8/v8@3176bfd
    
    PR-URL: nodejs#35612
    Refs: nodejs#35559
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    addaleax authored and targos committed Oct 17, 2020
    Copy the full SHA
    d06bb7d View commit details
    Browse the repository at this point in the history
  19. tools: update V8 gypfiles for 8.5

    ryzokuken authored and targos committed Oct 17, 2020
    Copy the full SHA
    67e998e View commit details
    Browse the repository at this point in the history
  20. Copy the full SHA
    dbd425a View commit details
    Browse the repository at this point in the history
  21. wasi: drop --experimental-wasm-bigint requirement

    After the V8 8.5 update, the WASI APIs no longer require the
    use of --experimental-wasm-bigint. This commit removes its use.
    cjihrig authored and targos committed Oct 17, 2020
    Copy the full SHA
    788046f View commit details
    Browse the repository at this point in the history
  22. tools: update V8 gypfiles for 8.6

    ryzokuken authored and targos committed Oct 17, 2020
    Copy the full SHA
    b2ae455 View commit details
    Browse the repository at this point in the history
  23. src: Implement NodePlatform::PostJob

    V8 is starting to use the job API for Wasm compilation, so the node
    platform should implement that.
    backes authored and targos committed Oct 17, 2020
    Copy the full SHA
    2a0b88c View commit details
    Browse the repository at this point in the history
  24. process: update v8 fast api calls usage

    This commit removes the WrapperTraits specialization for FastHrtime
    according to recent changes in the V8 API.
    
    Refs: nodejs#33374
    MayaLekova authored and targos committed Oct 17, 2020
    Copy the full SHA
    725b750 View commit details
    Browse the repository at this point in the history
  25. Copy the full SHA
    ecc85de View commit details
    Browse the repository at this point in the history