Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make MakeCallback() check can_call_into_js before getting method #35424

Closed
wants to merge 3 commits into from
Closed

src: make MakeCallback() check can_call_into_js before getting method #35424

wants to merge 3 commits into from

Commits on Sep 30, 2020

  1. src: make MakeCallback() check can_call_into_js before getting method 

    There is a check for this in the inner `MakeCallback()` function
called by it, but since the `Get()` call here can also result in a
call into JS, we should ideally check the flag before that.
    @addaleax
    addaleax committed Sep 30, 2020
    Copy the full SHA
    66ea016 View commit details
    Browse the repository at this point in the history

  2. fixup! src: make MakeCallback() check can_call_into_js before getting… 

    … method

Co-authored-by: Denys Otrishko <shishugi@gmail.com>
    @addaleax @lundibundi
    addaleax and lundibundi committed Sep 30, 2020
    Copy the full SHA
    fac7059 View commit details
    Browse the repository at this point in the history

  3. fixup! src: make MakeCallback() check can_call_into_js before getting… 

    … method
    @addaleax
    addaleax committed Sep 30, 2020
    Copy the full SHA
    3327dcd View commit details
    Browse the repository at this point in the history