Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move all base64.h inline methods into -inl.h header file #35432

Closed
wants to merge 1 commit into from
Closed

src: move all base64.h inline methods into -inl.h header file #35432

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #34944 (comment)

/cc @juanarbol

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 30, 2020
@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33304/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/33314/ (:green_heart:)

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2020

Landed in fdf0a84

nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2020
@addaleax @nodejs-github-bot
src: move all base64.h inline methods into -inl.h header file
fdf0a84 
Refs: #34944 (comment)

PR-URL: #35432
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@github-actions github-actions bot closed this Oct 3, 2020
@BethGriggs
Copy link
Member

Backport blocked on #34944 (comment)

joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@addaleax @joesepi
src: move all base64.h inline methods into -inl.h header file
e038f2a 
Refs: nodejs#34944 (comment)

PR-URL: nodejs#35432
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
@addaleax @targos
src: move all base64.h inline methods into -inl.h header file
bacd432 
Refs: #34944 (comment)

PR-URL: #35432
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@addaleax @nodejs-github-bot @BethGriggs @jasnell @Trott @joyeecheung @richardlau @gireeshpunathil @targos