Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 7.0.0-rc.0 #35447

Closed
wants to merge 1 commit into from
Closed

Conversation

darcyclarke
Copy link
Member

It's been awhile... reference to the 7.0.0-rc.0 specific release notes: https://github.com/npm/cli/releases/tag/v7.0.0-rc.0 & corresponding v7 CHANGELOG.md

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 1, 2020
@MylesBorins MylesBorins added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 1, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2020

@Trott
Copy link
Member

Trott commented Oct 2, 2020

This causes test/parallel/test-npm-version.js to fail. A seeming purpose of that test is to make sure we don't land npm rc's/betas/etc. Rather than altering the test, I think the thing to do is add an entry to test/parallel/parallel.status that turns the test yellow when it fails rather than red. This way, there's a clear indication in the CI that the code is not yet ready for release, but it won't stop other code from landing due to CI failing.

I think it would look like this:

[true] # This section applies to all platforms
# We temporarily have a npm rc. Allow test-npm-version to fail until it is
# removed.
# https://github.com/nodejs/node/pull/35447
test-npm-version: FLAKY

By using FLAKY and not PASS,FLAKY, I think the test will be required to fail. That will remind us to undo this when npm 7 is released for reals.

Another (perhaps simpler?) approach might be to move the test to test/known_issues where it will also be required to fail.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MylesBorins
Copy link
Member

Closing in lieu of #35474

@MylesBorins MylesBorins closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants