Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: minor error cleanups #35493

Merged
merged 2 commits into from Oct 6, 2020
Merged

src: minor error cleanups #35493

merged 2 commits into from Oct 6, 2020

Commits on Oct 6, 2020

  1. src: use env->ThrowUVException in pipe_wrap 

    Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @jasnell @Trott
    jasnell authored and Trott committed Oct 6, 2020
    Copy the full SHA
    530acd1 View commit details
    Browse the repository at this point in the history

  2. src: more idiomatic error pattern in node_wasi 

    Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#35493
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @jasnell @Trott
    jasnell authored and Trott committed Oct 6, 2020
    Copy the full SHA
    8beef5e View commit details
    Browse the repository at this point in the history