Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: mark/pop OpenSSL errors in NewRootCertStore #35514

Closed
wants to merge 3 commits into from

Commits on Oct 13, 2020

  1. src: mark/pop OpenSSL errors in NewRootCertStore

    This commit sets the OpenSSL error mark before calling
    X509_STORE_load_locations and pops the error mark afterwards.
    
    The motivation for this is that it is possible that
    X509_STORE_load_locations can produce errors if the configuration
    option --openssl-system-ca-path file does not exist. Later if a
    different function is called which calls an OpenSSL function it could
    fail because these errors might still be on the OpenSSL error stack.
    
    Currently, all functions that call NewRootCertStore clear the
    OpenSSL error queue upon returning, but this was not the case for
    example in v12.18.0.
    
    Fixes: nodejs#35456
    danbev committed Oct 13, 2020
    Copy the full SHA
    0ab510b View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. Copy the full SHA
    f7fd2ec View commit details
    Browse the repository at this point in the history
  2. squash: remove smartos ignore

    danbev committed Oct 18, 2020
    Copy the full SHA
    9117d4f View commit details
    Browse the repository at this point in the history