Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14.13.1 proposal #35525

Merged
merged 62 commits into from Oct 7, 2020
Merged

V14.13.1 proposal #35525

merged 62 commits into from Oct 7, 2020

Commits on Oct 6, 2020

  1. doc: make minor edits for consistency

    * We use _noop_ and _no-op_ in different docs. Use _no-op_ everywhere.
    * When referring to functions, add _()_ to indicate that.
    * Remove backticks from non-code _destroyed_.
    
    PR-URL: #35377
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    af360ac View commit details
    Browse the repository at this point in the history
  2. esm: use "node:" namespace for builtins

    PR-URL: #35387
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    guybedford authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    91b820e View commit details
    Browse the repository at this point in the history
  3. fs: use Promise.resolve from primordials

    PR-URL: #35379
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    e4a4f81 View commit details
    Browse the repository at this point in the history
  4. doc: align to function signature

    PR-URL: #34930
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    anlexN authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    998b24e View commit details
    Browse the repository at this point in the history
  5. tools: add pythonenv to .gitignore

    GitHub Codespaces installs a copy of Python 3.8 in the repository.
    
    PR-URL: #35389
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    4d29fb5 View commit details
    Browse the repository at this point in the history
  6. doc: update example ICU URL

    PR-URL: #35373
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    watilde authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    79e3e50 View commit details
    Browse the repository at this point in the history
  7. src: document required else block at src/node_platform.cc

    PR-URL: #34688
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    juanarbol authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    4aed176 View commit details
    Browse the repository at this point in the history
  8. tools: exclude gyp from markdown link checker

    The changelog format used in gyp-next does not comply to the rules.
    
    PR-URL: #35423
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    targos authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    a4e5a3a View commit details
    Browse the repository at this point in the history
  9. build: add support for section ordering

    Adds support for using a section ordering file with the gold linker.
    This makes it possible to reorder functions in a build to optimize for
    a specific workload.
    
    `hfsort` is a tool that can be used to generate such a file from perf-
    recorded last branch record (LBR) data by running Node.js as
    `node --perf-basic-prof`.
    
    Refs: https://github.com/facebook/hhvm/tree/9966d482c19c6120c621c6f3896525fb19fb3842/hphp/tools/hfsort
    Refs: https://software.intel.com/content/www/us/en/develop/articles/runtime-optimization-blueprint-IA-optimization-with-last-branch-record.html
    Refs: #16891
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    PR-URL: #35272
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Gabriel Schulhof authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    7dc6b2f View commit details
    Browse the repository at this point in the history
  10. module: refine module type mismatch error cases

    PR-URL: #35426
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    guybedford authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    f23a0e2 View commit details
    Browse the repository at this point in the history
  11. doc: use .md extension for internal links

    This helps catch broken links as part of the test suite. This also
    improves the user experience when browsing the markdown files.
    
    PR-URL: #35191
    Fixes: #35189
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    ce789f1 View commit details
    Browse the repository at this point in the history
  12. doc: sort md references in ASCII order

    Refs: #35244
    
    PR-URL: #35191
    Fixes: #35189
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    5a730b5 View commit details
    Browse the repository at this point in the history
  13. tools: check links in api docs

    Fixes: #35189
    
    PR-URL: #35191
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    166f14a View commit details
    Browse the repository at this point in the history
  14. console: add Symbol.toStringTag property

    Add Symbol.toStringTag property to console object to follow WPT changes
    Update WPT status of console and the repl test case
    
    Refs: web-platform-tests/wpt#24717
    
    PR-URL: #35399
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Leko authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    05e08bd View commit details
    Browse the repository at this point in the history
  15. doc: unhide resolver spec

    PR-URL: #35358
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    guybedford authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    d642788 View commit details
    Browse the repository at this point in the history
  16. doc: implement fancier rendering for keys

    Minimal CSS and markup changes to implement special rendering for
    `<kbd>` elements.
    
    PR-URL: #35400
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    86f2f83 View commit details
    Browse the repository at this point in the history
  17. doc: copyedit esm.md

    This provides a number of minor style adjustments and small corrections
    to esm.md text.
    
    Co-authored-by: Guy Bedford <guybedford@gmail.com>
    
    PR-URL: #35414
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    95c62a1 View commit details
    Browse the repository at this point in the history
  18. build: fix CQ after latest ncu release

    The new behavior of node-core-utils (which fetches the merge commit
    instead of fetching the patch files) requires the whole repo to be
    cloned, instead of just the last commit.
    
    PR-URL: #35468
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    mmarchini authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    f36476d View commit details
    Browse the repository at this point in the history
  19. doc: importable node protocol URLs

    PR-URL: #35434
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    bmeck authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    35b62ef View commit details
    Browse the repository at this point in the history
  20. doc: update contact information for richardlau

    PR-URL: #35450
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Stewart X Addison <sxa@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    richardlau authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    a11ddee View commit details
    Browse the repository at this point in the history
  21. meta: add startup team in CODEOWNERS

    PR-URL: #35406
    Fixes: #35215
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    2302206 View commit details
    Browse the repository at this point in the history
  22. doc: update contact information for @BethGriggs

    PR-URL: #35451
    Reviewed-By: Stewart X Addison <sxa@uk.ibm.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    BethGriggs authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    368a3ae View commit details
    Browse the repository at this point in the history
  23. doc: copyedit packages.md

    Some minor adjustments, mostly moving things to present tense and
    avoiding the ambiguity of _may_.
    
    Refs: #35370 (comment)
    
    PR-URL: #35427
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    4dbb3a9 View commit details
    Browse the repository at this point in the history
  24. tools,doc: fix broken link in module.html

    Update tools/doc/type-parser.js with correct URL for the
    module.SourceMap class. This fixes a broken link in our documentation.
    
    PR-URL: #35446
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    6e9e5c3 View commit details
    Browse the repository at this point in the history
  25. src: make MakeCallback() check can_call_into_js before getting method

    There is a check for this in the inner `MakeCallback()` function
    called by it, but since the `Get()` call here can also result in a
    call into JS, we should ideally check the flag before that.
    
    PR-URL: #35424
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    5a85d4f View commit details
    Browse the repository at this point in the history
  26. crypto: set env values in KeyObject Deserialize method

    Fixes: #35263
    
    PR-URL: #35416
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    ThakurKarthik authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    1f15e34 View commit details
    Browse the repository at this point in the history
  27. doc: added details around console.timeEnd changes

    Since PR #29251 is merged into
    master, the implementation of `console.timeEnd` is not to print the
    milliseconds on the stdout but instead print a more readable time unit
    on the console. For example if the total time comes out to be 3456
    milliseconds, it will be printed as 3.45 seconds so that it is much more
    readable and consistent.
    
    PR-URL: #35027
    Fixes: #35011
    Refs: #29251
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    yashLadha authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    862b75d View commit details
    Browse the repository at this point in the history
  28. fs: remove experimental from rmdir recursive

    Refs: #34278
    
    PR-URL: #35171
    Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    bcoe authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    fcbdb06 View commit details
    Browse the repository at this point in the history
  29. crypto: fix KeyObject garbage collection

    These objects don’t hold any resources on the event loop, so they
    should be weak objects that can be garbage collected when nothing
    refers to them anymore.
    
    PR-URL: #35481
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    a01154e View commit details
    Browse the repository at this point in the history
  30. src: remove invalid ToLocalChecked in EmitBeforeExit

    This call can fail, we should not use `.ToLocalChecked()` here.
    
    In the long run, we should use variants of `EmitExit()` and
    `EmitBeforeExit()` that avoid this problem by properly propagating
    empty `MaybeLocal`s.
    
    Example failure:
    
        21:07:17 not ok 2564 parallel/test-worker-terminate-source-map
        21:07:17   ---
        21:07:17   duration_ms: 0.385
        21:07:17   severity: crashed
        21:07:17   exitcode: -6
        21:07:17   stack: |-
        21:07:17     FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
        21:07:17      1: 0x1012f04a5 node::Abort() (.cold.1) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      2: 0x1000b52d9 node::Abort() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      3: 0x1000b543f node::OnFatalError(char const*, char const*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      4: 0x1001ffd70 v8::V8::ToLocalEmpty() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      5: 0x1000079b8 node::EmitBeforeExit(node::Environment*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      6: 0x100156fea node::worker::Worker::Run() [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      7: 0x10015a4d2 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/out/Release/node]
        21:07:17      8: 0x7fff72fe7109 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
        21:07:17      9: 0x7fff72fe2b8b thread_start [/usr/lib/system/libsystem_pthread.dylib]
        21:07:17   ...
    
    PR-URL: #35484
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    7bbf8ee View commit details
    Browse the repository at this point in the history
  31. doc: avoid using deprecated connection property

    `request.connection` and `response.connection` are deprecated. Use
    `request.socket` and `response.socket` instead.
    
    PR-URL: #35439
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    lpinca authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    38a5715 View commit details
    Browse the repository at this point in the history
  32. doc: add entry to console.timeEnd() changes array

    PR-URL: #35441
    Refs: #35027
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    lpinca authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    541ce17 View commit details
    Browse the repository at this point in the history
  33. doc: specify how to detect EOF

    Specify how to detect end-of-file when using `fs.read()` and
    `filehandle.read()`.
    
    PR-URL: #35445
    Fixes: #35363
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
    lpinca authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    e40876a View commit details
    Browse the repository at this point in the history
  34. deps: update llhttp to 2.1.3

    PR-URL: #35435
    Refs: nodejs/llhttp#65
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    indutny authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    85062b3 View commit details
    Browse the repository at this point in the history
  35. doc: fix conditional exports flag removal version

    PR-URL: #35428
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    3f95440 View commit details
    Browse the repository at this point in the history
  36. fs: simplify realpathSync

    PR-URL: #35413
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    himself65 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    f29451d View commit details
    Browse the repository at this point in the history
  37. tools: update gyp to 0.2.0

    PR-URL: #32698
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ryzokuken authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    190d46b View commit details
    Browse the repository at this point in the history
  38. tools: update gyp-next to v0.2.1

    PR-URL: #32698
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ryzokuken authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    7361a3f View commit details
    Browse the repository at this point in the history
  39. tools: update gyp-next to v0.3.0

    PR-URL: #32698
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ryzokuken authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    3e75907 View commit details
    Browse the repository at this point in the history
  40. tools: update gyp to v0.4.0

    PR-URL: #32698
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ryzokuken authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    ad8fce6 View commit details
    Browse the repository at this point in the history
  41. tools: update gyp to v0.5.0

    PR-URL: #32698
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    ryzokuken authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    5f1d792 View commit details
    Browse the repository at this point in the history
  42. meta: add nodejs/streams to CODEOWNERS

    PR-URL: #35411
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    mcollina authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    62ddc77 View commit details
    Browse the repository at this point in the history
  43. doc: update sxa's email address to Red Hat from IBM

    Signed-off-by: Stewart Addison <sxa@uk.ibm.com>
    
    PR-URL: #35442
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Stewart Addison authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    1313c8c View commit details
    Browse the repository at this point in the history
  44. tools: fix typo in error message

    PR-URL: #35417
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    f499302 View commit details
    Browse the repository at this point in the history
  45. doc: adopt MDN style for kbd elements

    PR-URL: #35460
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    885840b View commit details
    Browse the repository at this point in the history
  46. doc: mention adding YAML for APIs in PR contributing guide

    PR-URL: #35459
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    lundibundi authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    91ef862 View commit details
    Browse the repository at this point in the history
  47. module: fix builtin reexport tracing

    PR-URL: #35500
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    guybedford authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    5c879a9 View commit details
    Browse the repository at this point in the history
  48. doc: update AUTHORS list

    PR-URL: #35280
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    f08577c View commit details
    Browse the repository at this point in the history
  49. src: fix aliased buffer import warning in env.h

    Alliased buffer header is not imported in the `env.h` file due to which
    the language server is giving an error.
    
    Fixed it via importing the header file for "aliased_buffer.h"
    
    PR-URL: #35436
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    yashLadha authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    fbb9dd9 View commit details
    Browse the repository at this point in the history
  50. doc,esm: add history support info

    Documents which versions of Node.js support which ESM-feature.
    
    PR-URL: #35395
    Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    53e27b3 View commit details
    Browse the repository at this point in the history
  51. module: update to cjs-module-lexer@0.4.0

    PR-URL: #35501
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Masashi Hirano <shisama07@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    guybedford authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    0ac5fa7 View commit details
    Browse the repository at this point in the history
  52. doc: improve eventLoopUtilization documentation

    PR-URL: #35479
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    puzpuzpuz authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    6585b16 View commit details
    Browse the repository at this point in the history
  53. tools: add missing uv_setup_argv() calls

    Refs: #34751
    
    PR-URL: #35491
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    5790c40 View commit details
    Browse the repository at this point in the history
  54. src: limit GetProcessTitle() result to 1MB

    `GetProcessTitle()` otherwise runs an infinite loop when
    `uv_setup_argv()` has not been called (yet). This is a problem
    e.g. in assertions from static constructors, which run before
    `main()` and thus before `argc` and `argv` become available.
    
    To solve that, do not allocate more than 1MB of storage for the
    title and bail out if we reach that point.
    
    PR-URL: #35492
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    e09f7f0 View commit details
    Browse the repository at this point in the history
  55. fs: do not throw exception after creating FSReqCallback

    Once an `FSReqCallback` instance is created, it is a GC root until
    the underlying fs operation has completed, meaning that it cannot
    be garbage collected.
    
    This is a problem when the underlying operation never starts
    because an exception is thrown before that happens, for example
    as part of parameter validation.
    
    Instead, move all potentially throwing code before the `FSReqCallback`
    creation.
    
    PR-URL: #35487
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    541be52 View commit details
    Browse the repository at this point in the history
  56. test: improve test coverage for eventtarget

    PR-URL: #33733
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    juanarbol authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    27cd99b View commit details
    Browse the repository at this point in the history
  57. http2,tls: store WriteWrap using BaseObjectPtr

    Create weak `WriteWrap` and `ShutdownWrap` objects, and when
    referencing them in C++ is necessary, use `BaseObjectPtr<>`
    instead of plain pointers to keep these objects from being
    garbage-collected.
    
    This solves issues that arise when the underlying `StreamBase`
    instance is weak, but the `WriteWrap` or `ShutdownWrap` instances
    are not; in that case, they would otherwise potentially stick
    around in memory after the stream that they originally belong
    to is long gone.
    
    It probably makes sense to use `BaseObjectptr<>` more extensively
    in `StreamBase` in the long run as well.
    
    PR-URL: #35488
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    addaleax authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    8e3a81e View commit details
    Browse the repository at this point in the history
  58. src: use env->ThrowUVException in pipe_wrap

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #35493
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    392c881 View commit details
    Browse the repository at this point in the history
  59. src: more idiomatic error pattern in node_wasi

    Signed-off-by: James M Snell <jasnell@gmail.com>
    
    PR-URL: #35493
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    3f62f99 View commit details
    Browse the repository at this point in the history
  60. doc: revise introductory child_process text

    This consolidates information about Windows environment variables and
    has a few other smaller improvements (punctuation, present tense, etc.).
    
    PR-URL: #35344
    Backport-PR-URL: #35420
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    a995dd7 View commit details
    Browse the repository at this point in the history
  61. test: update wpt tests for encoding

    Refs: web-platform-tests/wpt#25542
    
    PR-URL: #35330
    Backport-PR-URL: #35422
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    watilde authored and danielleadams committed Oct 6, 2020
    Copy the full SHA
    552ebaf View commit details
    Browse the repository at this point in the history
  62. 2020-10-07, Version 14.13.1 (Current)

    Notable changes:
    
    * fs:
      * remove experimental from rmdir recursive (Benjamin Coe) [#35171](#35171)
    
    PR-URL: #35525
    danielleadams committed Oct 6, 2020
    Copy the full SHA
    7c5f319 View commit details
    Browse the repository at this point in the history