Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: unset NODE_VERSION_IS_RELEASE from master #35531

Closed
wants to merge 1 commit into from
Closed

src: unset NODE_VERSION_IS_RELEASE from master #35531

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 6, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@richardlau
Copy link
Member

I'd suggest fast tracking, but we also need to fix the docs build.

@aduh95
Copy link
Contributor Author

aduh95 commented Oct 6, 2020 •
edited

I'd suggest fast tracking, but we also need to fix the docs build.

That's being done in #35529

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2020
@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020
MylesBorins
MylesBorins approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33440/

MylesBorins pushed a commit that referenced this pull request Oct 7, 2020
@aduh95 @MylesBorins
src: unset NODE_VERSION_IS_RELEASE from master
bc0c094 
PR-URL: #35531
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Member

Landed in bc0c094

@MylesBorins MylesBorins closed this Oct 7, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
src: unset NODE_VERSION_IS_RELEASE from master
8e1c781 
PR-URL: nodejs#35531
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@aduh95 aduh95 deleted the patch-3 branch July 16, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aduh95 @richardlau @nodejs-github-bot @MylesBorins @devsnek @BethGriggs