Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve fs.rm() docs #35561

Merged
merged 2 commits into from Oct 10, 2020
Merged

doc: improve fs.rm() docs #35561

merged 2 commits into from Oct 10, 2020

Commits on Oct 10, 2020

  1. doc: make fs.rm()'s force docs consistent 

    This commit updates the documentation for the force option to
fs.rm(). Prior to this commit, the documentation was inconsistent
with the surrounding documentation.

PR-URL: nodejs#35561
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @cjihrig
    cjihrig committed Oct 10, 2020
    Copy the full SHA
    b8bd456 View commit details
    Browse the repository at this point in the history

  2. doc: remove incorrect synchronous label 

    fsPromises.rm() is not synchronous.

PR-URL: nodejs#35561
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @cjihrig
    cjihrig committed Oct 10, 2020
    Copy the full SHA
    71a48c3 View commit details
    Browse the repository at this point in the history