Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: small rmdir() and validateRmOptions() cleanup #35567

Merged
merged 2 commits into from Oct 11, 2020
Merged

fs: small rmdir() and validateRmOptions() cleanup #35567

merged 2 commits into from Oct 11, 2020

Commits on Oct 11, 2020

  1. fs: simplify validateRmOptions() error handling 

    PR-URL: nodejs#35567
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    @cjihrig
    cjihrig committed Oct 11, 2020
    Copy the full SHA
    94b0908 View commit details
    Browse the repository at this point in the history

  2. fs: remove extraneous assignments in rmdir() 

    validateRmOptions() doesn't return a value, so this commit
removes the assignment. The options passed to
validateRmdirOptions() are not used again after validation, so
this commit removes the assignment.

PR-URL: nodejs#35567
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    @cjihrig
    cjihrig committed Oct 11, 2020
    Copy the full SHA
    91e0d9b View commit details
    Browse the repository at this point in the history