Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert a new line to the API docs property in process.md #35610

Closed
wants to merge 1 commit into from
Closed

Insert a new line to the API docs property in process.md #35610

wants to merge 1 commit into from

Conversation

PoojaDurgad
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 12, 2020
addaleax
addaleax reviewed Oct 12, 2020
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Oct 12, 2020
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
Trott
Trott previously requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the file extension changed.

@Trott Trott dismissed their stale review October 14, 2020 12:13

file extension was changed

Trott
Trott reviewed Oct 27, 2020
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
gireeshpunathil pushed a commit that referenced this pull request Oct 31, 2020
@PoojaDurgad @gireeshpunathil
doc: add on statement in the APIs docs
1139a4a 
PR-URL: #35610
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@gireeshpunathil
Copy link
Member

landed in 1139a4a

targos pushed a commit that referenced this pull request Nov 3, 2020
@PoojaDurgad @targos
doc: add on statement in the APIs docs
337bfcf 
PR-URL: #35610
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@PoojaDurgad @BethGriggs
doc: add on statement in the APIs docs
a681dea 
PR-URL: #35610
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@PoojaDurgad @BethGriggs
doc: add on statement in the APIs docs
ba79a31 
PR-URL: #35610
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@PoojaDurgad @BethGriggs
doc: add on statement in the APIs docs
26e4293 
PR-URL: #35610
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@Trott Trott Trott approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@crypt096 crypt096 crypt096 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@PoojaDurgad @gireeshpunathil @Trott @addaleax @crypt096 @nodejs-github-bot