Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Remove reference to io.js #35618

Closed
wants to merge 1 commit into from
Closed

doc: Remove reference to io.js #35618

wants to merge 1 commit into from

Conversation

hexxdump
Copy link
Contributor

@hexxdump hexxdump commented Oct 12, 2020 •
edited

doc: Remove reference to io.js

io.js is outdated, hence removed reference to it from docs.

Fixes:#35580

Signed-off-by: Hussaina Begum Nandyala hexxdump@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 12, 2020
@hexxdump
Copy link
Contributor Author

Please review

Trott
Trott reviewed Oct 13, 2020
View reviewed changes
doc/api/process.md Outdated
@@ -1761,8 +1761,7 @@ tarball.

`process.release` contains the following properties:

* `name` {string} A value that will always be `'node'` for Node.js. For
legacy io.js releases, this will be `'io.js'`.
* `name` {string} A value that will always be `'node'` for Node.js.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `name` {string} A value that will always be `'node'` for Node.js.
* `name` {string} A value that will always be `'node'`.

@hexxdump
Copy link
Contributor Author

@Trott @gireeshpunathil @antsmartian @evanlucas, can these changes be merged now ?

@gireeshpunathil
Copy link
Member

@hexxdump - are you able to make changes as @Trott suggested above? (basically remove for Node.js and push again)

@hexxdump
Remove reference to io.js
6250587 
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>
@hexxdump
Copy link
Contributor Author

@gireeshpunathil, incorporated the changes suggested by @Trott

gireeshpunathil pushed a commit that referenced this pull request Oct 15, 2020
@hexxdump @gireeshpunathil
doc: Remove reference to io.js
4079bfd 
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>

PR-URL: #35618
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

landed in 4079bfd . thanks for the contribution!

@hexxdump
Copy link
Contributor Author

Thanks @gireeshpunathil, Its a very small change, I'm just getting started with OSS as part of Hacktoberfest. Will it be possible to mark this issue with 'hacktoberfest' label?

@gireeshpunathil
Copy link
Member

I don't see that label anymore! @Trott - do you know?

@Trott
Copy link
Member

Trott commented Oct 15, 2020

To my knowledge, only https://github.com/nodejs/docker-node and https://github.com/nodejs/nodejs.dev are participating in Hacktoberfest. No other nodejs repos are participating (as far as I am aware).

@hexxdump
Copy link
Contributor Author

To my knowledge, only https://github.com/nodejs/docker-node and https://github.com/nodejs/nodejs.dev are participating in Hacktoberfest. No other nodejs repos are participating (as far as I am aware).

No issues @Trott. I submitted another PR for Hactoberfest. Happy to see my first tiny commit in nodejs.

@lpinca lpinca mentioned this pull request Oct 26, 2020
Closed
MylesBorins pushed a commit that referenced this pull request Nov 24, 2020
@hexxdump @MylesBorins
doc: Remove reference to io.js
e71b4ba 
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>

PR-URL: #35618
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@hexxdump @joesepi
doc: Remove reference to io.js
c3d7064 
Signed-off-by: Hussaina Begum Nandyala <hexxdump@gmail.com>

PR-URL: nodejs#35618
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hexxdump @gireeshpunathil @Trott @jasnell @evanlucas @antsmartian @nodejs-github-bot