tools: update gyp-next to v0.6.0 #35635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
@rvagg can you push the test update commit into this branch? I believe you should be able to do that. |
|
fast-track? |
MylesBorins
added
fast-track
|
@MylesBorins I thought the change at node-gyp was more time sensitive? But either way, I'm 👍 for fast-tracking. |
github-actions
bot
removed
the
request-ci
|
@ryzokuken they are all time sensitive but afaik node-gyp itself doesn't have a fast track :P |
gengjiawen
approved these changes
Oct 14, 2020
|
cc @rvagg https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_shared_x64/22824/console 08:43:26 not ok 1526 parallel/test-module-loading-globalpaths
08:43:26 ---
08:43:26 duration_ms: 0.212
08:43:26 severity: fail
08:43:26 exitcode: 1
08:43:26 stack: |-
08:43:26 /home/iojs/node-tmp/.tmp.1526/install/bin/node: error while loading shared libraries: libnode.so.86: cannot open shared object file: No such file or directory
08:43:26 node:assert:680
08:43:26 throw err;
08:43:26 ^
08:43:26
08:43:26 AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Cannot find module 'foo'/. Input: |
github-actions
bot
removed
the
request-ci
|
this is good to go now, I've added in the commit from #35626 and CI is happy |
rvagg
approved these changes
Oct 14, 2020
|
Since everything passes and we agreed to fast-track this, I'm going to land this. |
ryzokuken
added a commit
that referenced
this pull request
Oct 14, 2020
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: #35635 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
ryzokuken
pushed a commit
that referenced
this pull request
Oct 14, 2020
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: #35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
|
Landed in d5e6495...999e7d7. 🎉 |
|
hey @nodejs/node-gyp should we be updating the version of gyp-next on v14.x LTS? If so can we get a backport PR so we can test it. |
@MylesBorins Yeap, backport looks good to me. |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: #35635 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: #35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: nodejs#35635 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Ref: nodejs/node-gyp#2233 Ref: nodejs/gyp-next#69 PR-URL: nodejs#35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
richardlau
pushed a commit
to richardlau/node-1
that referenced
this pull request
Aug 18, 2021
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: nodejs#35635 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @MylesBorins @rvagg @targos