Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: recommend test-doc instead of lint-md #35708

Merged
merged 3 commits into from Oct 30, 2020
Merged

doc: recommend test-doc instead of lint-md #35708

merged 3 commits into from Oct 30, 2020

Commits on Oct 30, 2020

  1. build,tools: add lint-js-doc target 

    Add a build target to lint JS code in Markdown files only.

PR-URL: nodejs#35708
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
    @aduh95
    aduh95 committed Oct 30, 2020
    Copy the full SHA
    0c61436 View commit details
    Browse the repository at this point in the history

  2. build: add vcbuilt test-doc target 

    PR-URL: nodejs#35708
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
    @aduh95
    aduh95 committed Oct 30, 2020
    Copy the full SHA
    b90e135 View commit details
    Browse the repository at this point in the history

  3. doc: recommend test-doc instead of lint-md 

    The documentation style guide used to recommend checking changes in the
docs by running `make lint-md`. This leaves out some important checks
which are contained in the `test-doc` build target. This commit also
replaces `lint` by `lint-md` in the list of `test-doc`'s prerequisites.

PR-URL: nodejs#35708
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
    @aduh95
    aduh95 committed Oct 30, 2020
    Copy the full SHA
    30e9fab View commit details
    Browse the repository at this point in the history