Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(automation): automatically update licenses weekly / on-demand #35712

Merged
merged 1 commit into from Oct 22, 2020

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 19, 2020

In #35577, I brought up that the license updating could be automated with relative ease using @gr2m's create-or-update-pull-request-action. I spent some time today between work getting this working. You can find an example in bnb#2 of how it works - specifically, note that the first commit (my commit!) removes the line that #335577 added, and then the action adds it back once it's done.

The action currently is set to allow for two triggers:

  • 00:00:00 on Monday, every week (I assume this is GMT?)
  • Manually from the GitHub Actions UI by anyone with permissions via the workflow_dispatch trigger. This is for the case where someone from the TSC or core knows there's an update and would prefer to not wait.
Checklist

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 19, 2020
PR-URL: nodejs#35712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@Trott Trott force-pushed the bnb/add-license-updater-action branch from f53b207 to 8f47e69 Compare October 22, 2020 12:25
@Trott
Copy link
Member

Trott commented Oct 22, 2020

Landed in 8f47e69

@Trott Trott merged commit 8f47e69 into nodejs:master Oct 22, 2020
@bnb bnb deleted the bnb/add-license-updater-action branch October 26, 2020 20:22
targos pushed a commit that referenced this pull request Nov 3, 2020
PR-URL: #35712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
PR-URL: #35712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
PR-URL: #35712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
PR-URL: #35712
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants