Commits on Oct 23, 2020

1. doc,src,test: revise C++ code for linter update …

   PR-URL: nodejs#35719
   Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
   Reviewed-By: Richard Lau <rlau@redhat.com>

   

   Trott committed Oct 23, 2020
   Copy the full SHA

   4fb7803 View commit details

   Browse the repository at this point in the history

2. tools: bump cpplint to 1.5.0 …

   https://github.com/cpplint/cpplint/releases/tag/1.5.0
   
   PR-URL: nodejs#35719
   Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
   Reviewed-By: Richard Lau <rlau@redhat.com>

   

   Trott committed Oct 23, 2020
   Copy the full SHA

   d9ed73c View commit details

   Browse the repository at this point in the history

3. tools: refloat 7 Node.js patches to cpplint.py …

   Cherry-pick 12c8b4d
   Original commit message:
       This commit is a suggestion for adding a rule for NULL usages in the
       code base. This will currently report a number of errors which could be
       ignored using // NOLINT (readability/null_usage)
   
       PR-URL: nodejs#17373
       Reviewed-By: Jon Moss <me@jonathanmoss.me>
       Reviewed-By: Anna Henningsen <anna@addaleax.net>
       Reviewed-By: Timothy Gu <timothygu99@gmail.com>
       Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
       Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
       Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
       Reviewed-By: Tobias Nießen <tniessen@tnie.de>
   
   Refs: nodejs@12c8b4d
   
   Cherry-pick fc81e80
   Original commit message:
   
       Update cpplint.py to check for inline headers when the corresponding
       header is already included.
   
       PR-URL: nodejs#21521
       Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
       Reviewed-By: James M Snell <jasnell@gmail.com>
   
   Refs: nodejs@fc81e80
   
   Cherry-pick cbc3dd9
   Original commit message:
   
       src, tools: add check for left leaning pointers
   
       This commit adds a rule to cpplint to check that pointers in the code
       base lean to the left and not right, and also fixes the violations
       reported.
   
       PR-URL: nodejs#21010
       Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
       Reviewed-By: Anna Henningsen <anna@addaleax.net>
       Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
       Reviewed-By: James M Snell <jasnell@gmail.com>
   
   Refs: nodejs@cbc3dd9
   
   Cherry-pick 9029981
   Original commit message:
   
       tools: fix cpplint.py header rules
   
       THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.
   
       PR-URL: nodejs#26306
       Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
   
   Refs: nodejs@9029981
   
   Cherry-pick 0a25ace
   Original commit message:
   
       tools: move cpplint configuration to .cpplint
   
       PR-URL: nodejs#27098
       Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
       Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
   
   Refs: nodejs@0a25ace
   
   Cherry-pick afa9a72
   Original commit message:
   
       tools: refloat update link to google styleguide for cpplint
   
       This commit updates two old links to Google's C++ styleguide which
       currently result in a 404 when accessed.
   
       PR-URL: nodejs#30876
       Reviewed-By: Michaël Zasso <targos@protonmail.com>
       Reviewed-By: David Carlier <devnexen@gmail.com>
       Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
       Reviewed-By: Richard Lau <riclau@uk.ibm.com>
       Reviewed-By: Rich Trott <rtrott@gmail.com>
   
   Refs: nodejs@afa9a72
   
   Cherry-pick e23bf8f
   Original commit message:
   
       tools,src: refloat forbid usage of v8::Persistent
   
       `v8::Persistent` comes with the surprising catch that it requires
       manual cleanup. `v8::Global` doesn’t, making it easier to use,
       and additionally provides move semantics. New code should always
       use `v8::Global`.
   
       PR-URL: nodejs#31018
       Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
       Reviewed-By: Richard Lau <riclau@uk.ibm.com>
       Reviewed-By: James M Snell <jasnell@gmail.com>
       Reviewed-By: David Carlier <devnexen@gmail.com>
       Reviewed-By: Rich Trott <rtrott@gmail.com>
       Reviewed-By: Gus Caplan <me@gus.host>
       Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
       Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
       Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
   
   PR-URL: nodejs#35569
   Reviewed-By: Richard Lau <rlau@redhat.com>
   Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
   Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
   
   PR-URL: nodejs#35719
   Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

   

   Trott committed Oct 23, 2020
   Copy the full SHA

   d233f10 View commit details

   Browse the repository at this point in the history