Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix stream as context is redundant #35728

Closed
wants to merge 1 commit into from
Closed

lib: fix stream as context is redundant #35728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/streams/from.js
View file
Open in desktop
Expand Up @@ -38,11 +38,11 @@ function from(Readable, iterable, opts) {
...opts
});

// Reading boolean to protect against _read
// Flag to protect against _read
// being called before last iteration completion.
let reading = false;

// needToClose boolean if iterator needs to be explicitly closed
// Flag for when iterator needs to be explicitly closed.
let needToClose = false;

readable._read = function() {
Expand Down