add a example code to API doc property in process.md #35738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example code added to the process.setgroups() API doc property in process.md
nodejs-github-bot
added
doc
Codecov Report
@@ Coverage Diff @@
## master #35738 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 220 223 +3
Lines 73675 73685 +10
=======================================
+ Hits 71025 71035 +10
Misses 2650 2650
Continue to review full report at Codecov.
|
Trott
reviewed
Oct 22, 2020
Trott
reviewed
Oct 22, 2020
|
I notice that L2207 indicates the array can only contain integers, but the text on L2213 correctly says it can also contain strings (group names). Might be good to update L2207. I'm not sure how to specify "an array of integers and/or strings" but |
Trott
approved these changes
Oct 22, 2020
lpinca
approved these changes
Oct 24, 2020
gireeshpunathil
approved these changes
Oct 25, 2020
gireeshpunathil
added
the
author ready
aduh95
pushed a commit
that referenced
this pull request
Oct 25, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in fc3f41b |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
example code added to the process.setgroups() API doc property in process.md PR-URL: #35738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example code added to the process.setgroups() API
doc property in process.md
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes