doc: update package.json field definitions #35741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together.
|
Review requested:
|
|
Thanks for looking into this. Agreed these are experimental right now. Whether this lands should depend on whether we are able to move to considering the modules implementation in general as stable at this point, as per discussion at the meeting today. I just checked my numbers wrt to the usage of these fields, and out of the 1.4 million packages on npm, the numbers for packages using these fields are:
If we were to consider the modules implementation stable, then given the above I don't think we could also consider exports or type experimental, as this is major stable usage in the wild now. I don't have usage numbers on exports patterns for example, but I expect it would still be low like imports. So I feel that only these specific features of |
guybedford
approved these changes
Oct 21, 2020
watilde
approved these changes
Oct 22, 2020
ryzokuken
approved these changes
Oct 22, 2020
Trott
reviewed
Oct 22, 2020
Trott
reviewed
Oct 22, 2020
Co-authored-by: Rich Trott <rtrott@gmail.com>
|
Landed in e6b1d74 |
MylesBorins
added a commit
that referenced
this pull request
Oct 23, 2020
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: #35741 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
|
I thought we weren’t going to reorder |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: #35741 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: #35741 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: #35741 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: #35741 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only imports has the experimental status right now but technically all
ESM related features are currently experimental. The list also doesn't
appear to be in any specific order so I've grouped the experimental
features together.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes