test: add upstream test cases to encoding #35794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
added
test
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Oct 25, 2020
watilde
added
the
author ready
jasnell
approved these changes
Oct 26, 2020
github-actions
bot
removed
the
request-ci
watilde
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/35794 ✔ Done loading data for nodejs/node/pull/35794 ----------------------------------- PR info ------------------------------------ Title test: add upstream test cases to encoding (#35794) Author Daijiro Wachi (@watilde) Branch watilde:wpt-encoding -> nodejs:master Labels author ready, encoding, test Commits 1 - test: add upstream test cases to encoding Committers 1 - Daijiro Wachi PR-URL: https://github.com/nodejs/node/pull/35794 Refs: https://github.com/web-platform-tests/wpt/pull/25988 Refs: https://github.com/web-platform-tests/wpt/pull/26158 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35794 Refs: https://github.com/web-platform-tests/wpt/pull/25988 Refs: https://github.com/web-platform-tests/wpt/pull/26158 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test: add upstream test cases to encoding ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-10-28T12:45:20Z: https://ci.nodejs.org/job/node-test-pull-request/33902/ - Querying data for job/node-test-pull-request/33902/ ✔ Build data downloaded - Querying failures of job/node-test-commit/41705/ ✔ Data downloaded ✖ 1 failure(s) on the last Jenkins CI run ℹ This PR was created on Sun, 25 Oct 2020 12:50:36 GMT ✔ Approvals: 3 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35794#pullrequestreview-516357694 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35794#pullrequestreview-516390612 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/35794#pullrequestreview-516925262 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/334784370 |
github-actions
bot
added
the
commit-queue-failed
watilde
added
request-ci
github-actions
bot
removed
the
request-ci
|
Landed in bec918f |
watilde
added a commit
that referenced
this pull request
Oct 29, 2020
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
Refs: web-platform-tests/wpt#25988 Refs: web-platform-tests/wpt#26158 PR-URL: #35794 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: web-platform-tests/wpt#25988
Refs: web-platform-tests/wpt#26158
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes