Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update MessagePort documentation for EventTarget inheritance #35839

Closed
wants to merge 1 commit into from
Closed

doc: update MessagePort documentation for EventTarget inheritance #35839

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #34057
Refs: #35835

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Oct 27, 2020
@addaleax
Copy link
Member Author

Feel free to 👍 to approve fast-tracking if you like

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 27, 2020
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 28, 2020
@github-actions
Copy link
Contributor

Landed in 3df5afb...ab660a5

@github-actions github-actions bot closed this Oct 28, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 28, 2020
@addaleax @nodejs-github-bot
doc: update MessagePort documentation for EventTarget inheritance
ab660a5 
Refs: #34057
Refs: #35835

PR-URL: #35839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax deleted the worker-messageport-ee branch October 28, 2020 11:30
targos pushed a commit that referenced this pull request Nov 3, 2020
@addaleax @targos
doc: update MessagePort documentation for EventTarget inheritance
4e76a3c 
Refs: #34057
Refs: #35835

PR-URL: #35839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@addaleax @BethGriggs
doc: update MessagePort documentation for EventTarget inheritance
cd6a441 
Refs: #34057
Refs: #35835

PR-URL: #35839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@addaleax @BethGriggs
doc: update MessagePort documentation for EventTarget inheritance
b62090d 
Refs: #34057
Refs: #35835

PR-URL: #35839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@addaleax @BethGriggs
doc: update MessagePort documentation for EventTarget inheritance
02f9a2a 
Refs: #34057
Refs: #35835

PR-URL: #35839
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@addaleax @Trott @lpinca @targos @nodejs-github-bot