Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Document version introducing ChildProcess 'spawn' event #35846

Closed

Conversation

zenflow
Copy link
Contributor

@zenflow zenflow commented Oct 28, 2020

This replaces a placeholder that was added in the commit which added
the new ChildProcess 'spawn' event.

Refs: #35369

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

As per my final paragraph in this comment

/cc @gireeshpunathil

This replaces a placeholder that was added in the commit which added
the new ChildProcess 'spawn' event.

Refs: nodejs#35369
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Oct 28, 2020
@gireeshpunathil
Copy link
Member

@zenflow - we don't have to do explicitly, when a release is being cut out of the current master, the then release number will replace the REPLACEME verb.

@gireeshpunathil
Copy link
Member

I see that you had asked this question earlier, sorry - I missed it.

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do it like this so we can document multiple versions when features get backported to LTS lines. The PR you are referencing is labeled semver-minor, it should land on v15 first, and 2+ weeks later on v14 and v12. Nothing to do on your side unless the commit doesn't land cleanly in case a manual backport will be requested.

@zenflow
Copy link
Contributor Author

zenflow commented Oct 28, 2020

@gireeshpunathil Thanks and no problem! :)

@zenflow
Copy link
Contributor Author

zenflow commented Oct 28, 2020

@aduh95 Awesome! Thanks for explaining how this works, very helpful :)

@zenflow zenflow closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants