Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise v8.getHeapSnapshot() #35849

Merged
merged 1 commit into from Nov 6, 2020
Merged

doc: revise v8.getHeapSnapshot() #35849

merged 1 commit into from Nov 6, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 28, 2020

  • move entry above v8.getHeapSpaceStatistics() (where it belongs
    alphabetically and is not out of place logically)
  • split lengthy sentence into two sentences
Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 28, 2020
@Trott
Copy link
Member Author

Trott commented Oct 30, 2020

@nodejs/documentation

Copy link
Member

@a0viedo a0viedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: nodejs#35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
@Trott
Copy link
Member Author

Trott commented Nov 6, 2020

Landed in ec400f8

@Trott Trott merged commit ec400f8 into nodejs:master Nov 6, 2020
@Trott Trott deleted the v8heapsnapshot branch November 6, 2020 13:01
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
* move entry above v8.getHeapSpaceStatistics() (where it belongs
  alphabetically and is not out of place logically)
* split lengthy sentence into two sentences

PR-URL: #35849
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants