test: mark test-http2-respond-file-error-pipe-offset flaky #35883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: nodejs#35881
MylesBorins
added
flaky-test
|
Can we please fast-track |
github-actions
bot
removed
the
request-ci
tniessen
approved these changes
Oct 30, 2020
|
See #35881 (comment). |
gireeshpunathil
approved these changes
Oct 30, 2020
|
The failure happening in BSD is unrelated to the PR. I've opened another PR to mark the offending test as flaky as well Going to land this |
|
Landed in 5da2512 |
MylesBorins
added a commit
that referenced
this pull request
Oct 30, 2020
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: #35881 PR-URL: #35883 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: #35881 PR-URL: #35883 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: #35881 PR-URL: #35883 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: #35881 PR-URL: #35883 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
This is now failing inconsistently across many platforms. This appears to be the result of the addition of mustSucceed being added to the test during testing refactoring. We should mark flaky until we have figured out what the issue is. Refs: #35881 PR-URL: #35883 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now failing inconsistently across many platforms. This
appears to be the result of the addition of mustSucceed being
added to the test during testing refactoring.
We should mark flaky until we have figured out what the issue
is.
Refs: #35881
/cc @Trott @tniessen