Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: refactor to use iterable-weak-map #35915

Closed
wants to merge 10 commits into from
Closed

module: refactor to use iterable-weak-map #35915

wants to merge 10 commits into from

Commits on Nov 5, 2020

  1. module: refactor to use iterable-weak-map 

    Using an iterable WeakMap (a data-structure that uses WeakRef and
WeakMap), we are able to: stop relying on Module._cache to
serialize source maps; stop requiring an error object when calling
findSourceMap().
    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    414ea74 View commit details
    Browse the repository at this point in the history

  2. test: add test for iterable-source-map fix

    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    3ca2431 View commit details
    Browse the repository at this point in the history

  3. build: fix naming

    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    9d5d45d View commit details
    Browse the repository at this point in the history

  4. Update test/parallel/test-source-map-enable.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @bcoe @aduh95
    bcoe and aduh95 committed Nov 5, 2020
    Copy the full SHA
    e156fa1 View commit details
    Browse the repository at this point in the history

  5. test: add tests for iterable-weak-map

    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    5a80dfd View commit details
    Browse the repository at this point in the history

  6. chore: address review

    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    46e0bba View commit details
    Browse the repository at this point in the history

  7. fix: switch from name to id 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @bcoe @aduh95
    bcoe and aduh95 committed Nov 5, 2020
    Copy the full SHA
    6434455 View commit details
    Browse the repository at this point in the history

  8. chore: address code review

    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    0b30bc2 View commit details
    Browse the repository at this point in the history

  9. chore: address code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @bcoe @aduh95
    bcoe and aduh95 committed Nov 5, 2020
    Copy the full SHA
    e994511 View commit details
    Browse the repository at this point in the history

  10. chore: address code review

    @bcoe
    bcoe committed Nov 5, 2020
    Copy the full SHA
    f1d088a View commit details
    Browse the repository at this point in the history