Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix lint-js-fix target #35927

Closed
wants to merge 1 commit into from
Closed

build: fix lint-js-fix target #35927

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 2, 2020 

$ make lint-js-fix
No value for 'ext' specified.
make: *** [lint-js-fix] Error 2

Bug introduced in #35708

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@aduh95 aduh95 added build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 2, 2020
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 2, 2020

Fast track?

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34020/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020 •
edited by aduh95

Landed in bf6883d

nodejs-github-bot pushed a commit that referenced this pull request Nov 2, 2020
@aduh95 @nodejs-github-bot
build: fix lint-js-fix target
bf6883d 
Refs: #35708

PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actions github-actions bot closed this Nov 2, 2020
@aduh95 aduh95 deleted the fix-lint-js-fix branch November 2, 2020 22:48
targos pushed a commit that referenced this pull request Nov 3, 2020
@aduh95 @targos
build: fix lint-js-fix target
b11c737 
Refs: #35708

PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@aduh95 @BethGriggs
build: fix lint-js-fix target
a389a72 
Refs: #35708

PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@aduh95 @BethGriggs
build: fix lint-js-fix target
a01802d 
Refs: #35708

PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@aduh95 @BethGriggs
build: fix lint-js-fix target
f33fa26 
Refs: #35708

PR-URL: #35927
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aduh95 @nodejs-github-bot @benjamingr @lpinca @richardlau