Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix regression on duplex end #35941

Merged
merged 1 commit into from Nov 4, 2020
Merged

stream: fix regression on duplex end #35941

merged 1 commit into from Nov 4, 2020

Commits on Nov 4, 2020

  1. stream: fix regression on duplex end 

    Decide the return status of writeOrBuffer before
calling stream.write which can reset state.length

Add unit test for nodejs#35926

Refs: nodejs#35926

PR-URL: nodejs#35941
Fixes: nodejs#35926
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @mmomtchev @Trott
    mmomtchev authored and Trott committed Nov 4, 2020
    Copy the full SHA
    5a3f43b View commit details
    Browse the repository at this point in the history